pvrusb2: Remove comment lines which refer to checkpatch's behavior

From: Mike Isely <isely@pobox.com>

Priority: normal

Signed-off-by: Mike Isely <isely@pobox.com>

5 files changed, 2 insertions, 35 deletions

diff --git a/linux/drivers/media/video/pvrusb2/pvrusb2-ctrl.c b/linux/drivers/media/video/pvrusb2/pvrusb2-ctrl.c
index fb2ed3cb7..5fa8af50b 100644
--- a/linux/drivers/media/video/pvrusb2/pvrusb2-ctrl.c
+++ b/linux/drivers/media/video/pvrusb2/pvrusb2-ctrl.c
@@ -142,10 +142,8 @@ int pvr2_ctrl_get_def(struct pvr2_ctrl *cptr, int *valptr)
 	LOCK_TAKE(cptr->hdw->big_lock); do {
 		if (cptr->info->type == pvr2_ctl_int) {
 			if (cptr->info->get_def_value) {
-				/* Comment to keep checkpatch.pl quiet */
 				ret = cptr->info->get_def_value(cptr, valptr);
 			} else {
-				/* Comment to keep checkpatch.pl quiet */
 				*valptr = cptr->info->default_value;
 			}
 		}
diff --git a/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c b/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c
index a517fd6f8..b79829f8a 100644
--- a/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c
+++ b/linux/drivers/media/video/pvrusb2/pvrusb2-hdw.c
@@ -409,7 +409,6 @@ static int ctrl_cropl_min_get(struct pvr2_ctrl *cptr, int *left)
 	struct v4l2_cropcap *cap = &cptr->hdw->cropcap_info;
 	int stat = pvr2_hdw_check_cropcap(cptr->hdw);
 	if (stat != 0) {
-		/* Keep checkpatch.pl quiet */
 		return stat;
 	}
 	*left = cap->bounds.left;
@@ -421,13 +420,10 @@ static int ctrl_cropl_max_get(struct pvr2_ctrl *cptr, int *left)
 	struct v4l2_cropcap *cap = &cptr->hdw->cropcap_info;
 	int stat = pvr2_hdw_check_cropcap(cptr->hdw);
 	if (stat != 0) {
-		/* Keep checkpatch.pl quiet */
 		return stat;
 	}
 	*left = cap->bounds.left;
 	if (cap->bounds.width > cptr->hdw->cropw_val) {
-		/* This statement is present purely to shut up
-		   checkpatch.pl */
 		*left += cap->bounds.width - cptr->hdw->cropw_val;
 	}
 	return 0;
@@ -438,7 +434,6 @@ static int ctrl_cropt_min_get(struct pvr2_ctrl *cptr, int *top)
 	struct v4l2_cropcap *cap = &cptr->hdw->cropcap_info;
 	int stat = pvr2_hdw_check_cropcap(cptr->hdw);
 	if (stat != 0) {
-		/* Keep checkpatch.pl quiet */
 		return stat;
 	}
 	*top = cap->bounds.top;
@@ -450,12 +445,10 @@ static int ctrl_cropt_max_get(struct pvr2_ctrl *cptr, int *top)
 	struct v4l2_cropcap *cap = &cptr->hdw->cropcap_info;
 	int stat = pvr2_hdw_check_cropcap(cptr->hdw);
 	if (stat != 0) {
-		/* Keep checkpatch.pl quiet */
 		return stat;
 	}
 	*top = cap->bounds.top;
 	if (cap->bounds.height > cptr->hdw->croph_val) {
-		/* Keep checkpatch.pl quiet */
 		*top += cap->bounds.height - cptr->hdw->croph_val;
 	}
 	return 0;
@@ -466,12 +459,10 @@ static int ctrl_cropw_max_get(struct pvr2_ctrl *cptr, int *val)
 	struct v4l2_cropcap *cap = &cptr->hdw->cropcap_info;
 	int stat = pvr2_hdw_check_cropcap(cptr->hdw);
 	if (stat != 0) {
-		/* Keep checkpatch.pl quiet */
 		return stat;
 	}
 	*val = 0;
 	if (cap->bounds.width > cptr->hdw->cropl_val) {
-		/* Keep checkpatch.pl quiet */
 		*val = cap->bounds.width - cptr->hdw->cropl_val;
 	}
 	return 0;
@@ -482,12 +473,10 @@ static int ctrl_croph_max_get(struct pvr2_ctrl *cptr, int *val)
 	struct v4l2_cropcap *cap = &cptr->hdw->cropcap_info;
 	int stat = pvr2_hdw_check_cropcap(cptr->hdw);
 	if (stat != 0) {
-		/* Keep checkpatch.pl quiet */
 		return stat;
 	}
 	*val = 0;
 	if (cap->bounds.height > cptr->hdw->cropt_val) {
-		/* Keep checkpatch.pl quiet */
 		*val = cap->bounds.height - cptr->hdw->cropt_val;
 	}
 	return 0;
@@ -498,7 +487,6 @@ static int ctrl_get_cropcapbl(struct pvr2_ctrl *cptr, int *val)
 	struct v4l2_cropcap *cap = &cptr->hdw->cropcap_info;
 	int stat = pvr2_hdw_check_cropcap(cptr->hdw);
 	if (stat != 0) {
-		/* Keep checkpatch.pl quiet */
 		return stat;
 	}
 	*val = cap->bounds.left;
@@ -510,7 +498,6 @@ static int ctrl_get_cropcapbt(struct pvr2_ctrl *cptr, int *val)
 	struct v4l2_cropcap *cap = &cptr->hdw->cropcap_info;
 	int stat = pvr2_hdw_check_cropcap(cptr->hdw);
 	if (stat != 0) {
-		/* Keep checkpatch.pl quiet */
 		return stat;
 	}
 	*val = cap->bounds.top;
@@ -522,7 +509,6 @@ static int ctrl_get_cropcapbw(struct pvr2_ctrl *cptr, int *val)
 	struct v4l2_cropcap *cap = &cptr->hdw->cropcap_info;
 	int stat = pvr2_hdw_check_cropcap(cptr->hdw);
 	if (stat != 0) {
-		/* Keep checkpatch.pl quiet */
 		return stat;
 	}
 	*val = cap->bounds.width;
@@ -534,7 +520,6 @@ static int ctrl_get_cropcapbh(struct pvr2_ctrl *cptr, int *val)
 	struct v4l2_cropcap *cap = &cptr->hdw->cropcap_info;
 	int stat = pvr2_hdw_check_cropcap(cptr->hdw);
 	if (stat != 0) {
-		/* Keep checkpatch.pl quiet */
 		return stat;
 	}
 	*val = cap->bounds.height;
@@ -546,7 +531,6 @@ static int ctrl_get_cropcapdl(struct pvr2_ctrl *cptr, int *val)
 	struct v4l2_cropcap *cap = &cptr->hdw->cropcap_info;
 	int stat = pvr2_hdw_check_cropcap(cptr->hdw);
 	if (stat != 0) {
-		/* Keep checkpatch.pl quiet */
 		return stat;
 	}
 	*val = cap->defrect.left;
@@ -558,7 +542,6 @@ static int ctrl_get_cropcapdt(struct pvr2_ctrl *cptr, int *val)
 	struct v4l2_cropcap *cap = &cptr->hdw->cropcap_info;
 	int stat = pvr2_hdw_check_cropcap(cptr->hdw);
 	if (stat != 0) {
-		/* Keep checkpatch.pl quiet */
 		return stat;
 	}
 	*val = cap->defrect.top;
@@ -570,7 +553,6 @@ static int ctrl_get_cropcapdw(struct pvr2_ctrl *cptr, int *val)
 	struct v4l2_cropcap *cap = &cptr->hdw->cropcap_info;
 	int stat = pvr2_hdw_check_cropcap(cptr->hdw);
 	if (stat != 0) {
-		/* Keep checkpatch.pl quiet */
 		return stat;
 	}
 	*val = cap->defrect.width;
@@ -582,7 +564,6 @@ static int ctrl_get_cropcapdh(struct pvr2_ctrl *cptr, int *val)
 	struct v4l2_cropcap *cap = &cptr->hdw->cropcap_info;
 	int stat = pvr2_hdw_check_cropcap(cptr->hdw);
 	if (stat != 0) {
-		/* Keep checkpatch.pl quiet */
 		return stat;
 	}
 	*val = cap->defrect.height;
@@ -594,7 +575,6 @@ static int ctrl_get_cropcappan(struct pvr2_ctrl *cptr, int *val)
 	struct v4l2_cropcap *cap = &cptr->hdw->cropcap_info;
 	int stat = pvr2_hdw_check_cropcap(cptr->hdw);
 	if (stat != 0) {
-		/* Keep checkpatch.pl quiet */
 		return stat;
 	}
 	*val = cap->pixelaspect.numerator;
@@ -606,7 +586,6 @@ static int ctrl_get_cropcappad(struct pvr2_ctrl *cptr, int *val)
 	struct v4l2_cropcap *cap = &cptr->hdw->cropcap_info;
 	int stat = pvr2_hdw_check_cropcap(cptr->hdw);
 	if (stat != 0) {
-		/* Keep checkpatch.pl quiet */
 		return stat;
 	}
 	*val = cap->pixelaspect.denominator;
@@ -3032,12 +3011,10 @@ void pvr2_hdw_execute_tuner_poll(struct pvr2_hdw *hdw)
 static int pvr2_hdw_check_cropcap(struct pvr2_hdw *hdw)
 {
 	if (!hdw->cropcap_stale) {
-		/* Keep checkpatch.pl quiet */
 		return 0;
 	}
 	pvr2_i2c_core_status_poll(hdw);
 	if (hdw->cropcap_stale) {
-		/* Keep checkpatch.pl quiet */
 		return -EIO;
 	}
 	return 0;
@@ -3051,7 +3028,6 @@ int pvr2_hdw_get_cropcap(struct pvr2_hdw *hdw, struct v4l2_cropcap *pp)
 	LOCK_TAKE(hdw->big_lock);
 	stat = pvr2_hdw_check_cropcap(hdw);
 	if (!stat) {
-		/* Keep checkpatch.pl quiet */
 		memcpy(pp, &hdw->cropcap_info, sizeof(hdw->cropcap_info));
 	}
 	LOCK_GIVE(hdw->big_lock);
diff --git a/linux/drivers/media/video/pvrusb2/pvrusb2-i2c-cmd-v4l2.c b/linux/drivers/media/video/pvrusb2/pvrusb2-i2c-cmd-v4l2.c
index ae2ee9b59..ab703d6d5 100644
--- a/linux/drivers/media/video/pvrusb2/pvrusb2-i2c-cmd-v4l2.c
+++ b/linux/drivers/media/video/pvrusb2/pvrusb2-i2c-cmd-v4l2.c
@@ -255,12 +255,8 @@ static void set_crop(struct pvr2_hdw *hdw)
 
 static int check_crop(struct pvr2_hdw *hdw)
 {
-	/* The "0 +" stupidity is present only to get checkpatch.pl to
-	   shut up.  I _want_ those parantheses present so that the
-	   two lines automatically line up in my editor.  I despise
-	   checkpatch.pl. */
-	return 0 + (hdw->cropl_dirty || hdw->cropt_dirty ||
-		    hdw->cropw_dirty || hdw->croph_dirty);
+	return (hdw->cropl_dirty || hdw->cropt_dirty ||
+		hdw->cropw_dirty || hdw->croph_dirty);
 }
 
 const struct pvr2_i2c_op pvr2_i2c_op_v4l2_crop = {
diff --git a/linux/drivers/media/video/pvrusb2/pvrusb2-i2c-core.c b/linux/drivers/media/video/pvrusb2/pvrusb2-i2c-core.c
index 6161657af..37946058f 100644
--- a/linux/drivers/media/video/pvrusb2/pvrusb2-i2c-core.c
+++ b/linux/drivers/media/video/pvrusb2/pvrusb2-i2c-core.c
@@ -1067,8 +1067,6 @@ void pvr2_i2c_core_init(struct pvr2_hdw *hdw)
 		hdw->i2c_func[0x18] = i2c_black_hole;
 	} else if (ir_mode[hdw->unit_number] == 1) {
 		if (hdw->hdw_desc->ir_scheme == PVR2_IR_SCHEME_24XXX) {
-			/* This comment is present PURELY to get
-			   checkpatch.pl to STFU.  Lovely, eh? */
 			hdw->i2c_func[0x18] = i2c_24xxx_ir;
 		}
 	}
diff --git a/linux/drivers/media/video/pvrusb2/pvrusb2-sysfs.c b/linux/drivers/media/video/pvrusb2/pvrusb2-sysfs.c
index b50565d27..16461dd92 100644
--- a/linux/drivers/media/video/pvrusb2/pvrusb2-sysfs.c
+++ b/linux/drivers/media/video/pvrusb2/pvrusb2-sysfs.c
@@ -159,7 +159,6 @@ static ssize_t show_def(struct device *class_dev,
 	pvr2_sysfs_trace("pvr2_sysfs(%p) show_def(cid=%d) is %d, stat=%d",
 			 cip->chptr, cip->ctl_id, val, ret);
 	if (ret < 0) {
-		/* Keep checkpatch.pl quiet */
 		return ret;
 	}
 	return scnprintf(buf, PAGE_SIZE, "%d\n", val);