diff options
| author | Mauro Carvalho Chehab <mchehab@infradead.org> | 2008-04-23 14:27:27 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@infradead.org> | 2008-04-23 14:27:27 -0300 |
| commit | 52e1a0cb22cc2caac3faa63d0e7e0039791816a4 (patch) | |
| tree | 2f1b273287803b4178ed51fde60a131397ef26f4 /linux | |
| parent | 6bb75de85d2b36b4e02be0e57279e2b7f33c9a38 (diff) | |
| download | mediapointer-dvb-s2-52e1a0cb22cc2caac3faa63d0e7e0039791816a4.tar.gz mediapointer-dvb-s2-52e1a0cb22cc2caac3faa63d0e7e0039791816a4.tar.bz2 | |
tea5761: bugzilla #10462: tea5761 autodetection code were broken
From: Mauro Carvalho Chehab <mchehab@infradead.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Diffstat (limited to 'linux')
| -rw-r--r-- | linux/drivers/media/video/tea5761.c | 15 | ||||
| -rw-r--r-- | linux/drivers/media/video/tuner-core.c | 6 |
2 files changed, 13 insertions, 8 deletions
diff --git a/linux/drivers/media/video/tea5761.c b/linux/drivers/media/video/tea5761.c index fa1d12d6f..11e2991ef 100644 --- a/linux/drivers/media/video/tea5761.c +++ b/linux/drivers/media/video/tea5761.c @@ -248,14 +248,19 @@ int tea5761_autodetection(struct i2c_adapter* i2c_adap, u8 i2c_addr) if (16 != (rc = tuner_i2c_xfer_recv(&i2c, buffer, 16))) { printk(KERN_WARNING "it is not a TEA5761. Received %i chars.\n", rc); - return EINVAL; + return -EINVAL; } - if (!((buffer[13] != 0x2b) || (buffer[14] != 0x57) || (buffer[15] != 0x061))) { - printk(KERN_WARNING "Manufacturer ID= 0x%02x, Chip ID = %02x%02x. It is not a TEA5761\n",buffer[13],buffer[14],buffer[15]); - return EINVAL; + if ((buffer[13] != 0x2b) || (buffer[14] != 0x57) || (buffer[15] != 0x061)) { + printk(KERN_WARNING "Manufacturer ID= 0x%02x, Chip ID = %02x%02x." + " It is not a TEA5761\n", + buffer[13], buffer[14], buffer[15]); + return -EINVAL; } - printk(KERN_WARNING "TEA5761 detected.\n"); + printk(KERN_WARNING "tea5761: TEA%02x%02x detected. " + "Manufacturer ID= 0x%02x\n", + buffer[14], buffer[15], buffer[13]); + return 0; } diff --git a/linux/drivers/media/video/tuner-core.c b/linux/drivers/media/video/tuner-core.c index fa218e910..42903463d 100644 --- a/linux/drivers/media/video/tuner-core.c +++ b/linux/drivers/media/video/tuner-core.c @@ -1155,8 +1155,8 @@ static int tuner_probe(struct i2c_client *client) if (!no_autodetect) { switch (client->addr) { case 0x10: - if (tea5761_autodetection(t->i2c->adapter, t->i2c->addr) - != EINVAL) { + if (tea5761_autodetection(t->i2c->adapter, + t->i2c->addr) >= 0) { t->type = TUNER_TEA5761; t->mode_mask = T_RADIO; t->mode = T_STANDBY; @@ -1168,7 +1168,7 @@ static int tuner_probe(struct i2c_client *client) goto register_client; } - break; + return -ENODEV; case 0x42: case 0x43: case 0x4a: |