diff options
| author | Mauro Carvalho Chehab <mchehab@redhat.com> | 2009-03-08 23:01:08 -0300 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2009-03-08 23:01:08 -0300 |
| commit | 78a6eb45bbd3dfed11a9ac8287a6060464eba7ba (patch) | |
| tree | 028b7b2428b647c56167a0e2e0c81bda6d8a49e9 /linux | |
| parent | 1bd1aedc7af71728404f5d7b059dd8ca52d01f9f (diff) | |
| download | mediapointer-dvb-s2-78a6eb45bbd3dfed11a9ac8287a6060464eba7ba.tar.gz mediapointer-dvb-s2-78a6eb45bbd3dfed11a9ac8287a6060464eba7ba.tar.bz2 | |
dvb/frontends: fix duplicate 'debug' symbol
From: Randy Dunlap <randy.dunlap@oracle.com>
Fix dvb frontend debug variable to be static, to avoid linker
errors:
drivers/built-in.o:(.data+0xf4b0): multiple definition of `debug'
arch/x86/kernel/built-in.o:(.kprobes.text+0x90): first defined here
ld: Warning: size of symbol `debug' changed from 85 in arch/x86/kernel/built-in.o to 4 in drivers/built-in.o
It would also be Good if arch/x86/kernel/entry_32.S didn't have a
non-static 'debug' symbol. OTOH, it helps catch things like this one.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'linux')
| -rw-r--r-- | linux/drivers/media/dvb/frontends/stv0900_core.c | 4 | ||||
| -rw-r--r-- | linux/drivers/media/dvb/frontends/stv0900_priv.h | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/linux/drivers/media/dvb/frontends/stv0900_core.c b/linux/drivers/media/dvb/frontends/stv0900_core.c index c86c3017e..9ff9744a1 100644 --- a/linux/drivers/media/dvb/frontends/stv0900_core.c +++ b/linux/drivers/media/dvb/frontends/stv0900_core.c @@ -34,8 +34,8 @@ #include "stv0900_priv.h" #include "stv0900_init.h" -int debug = 1; -module_param(debug, int, 0644); +static int stvdebug = 1; +module_param_named(debug, stvdebug, int, 0644); /* internal params node */ struct stv0900_inode { diff --git a/linux/drivers/media/dvb/frontends/stv0900_priv.h b/linux/drivers/media/dvb/frontends/stv0900_priv.h index 28350fbeb..762d5af62 100644 --- a/linux/drivers/media/dvb/frontends/stv0900_priv.h +++ b/linux/drivers/media/dvb/frontends/stv0900_priv.h @@ -62,11 +62,11 @@ #define dmd_choose(a, b) (demod = STV0900_DEMOD_2 ? b : a)) -extern int debug; +static int stvdebug; #define dprintk(args...) \ do { \ - if (debug) \ + if (stvdebug) \ printk(KERN_DEBUG args); \ } while (0) |