summaryrefslogtreecommitdiff
path: root/linux/drivers/media/video/cx88
AgeCommit message (Collapse)Author
2008-12-18cx88: advise/acquire clean-up for HVR-1300/3000/4000Mauro Carvalho Chehab
From: Darron Broad <darron@kewl.org> This cleans-up the advise/acquire methods. This has been tested on the hvr-1300/4000 and assumed to be correct on the hvr-3000. This update also fixes analogue tuning on the hvr-1300 when in blackbird mode. Priority: normal Signed-off-by: Darron Broad <darron@kewl.org> CC: Steven Toth <stoth@hauppauge.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2008-12-16Revert changeset 9886Mauro Carvalho Chehab
From: Mauro Carvalho Chehab <mchehab@redhat.com> Changeset 9886 were applied by mistake, reverting changeset 9885, that got a wrong comment. Let's revert it. Priority: normal Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2008-12-02drivers/media/video/cx88/cx88-alsa.c: Adjust error-handling codeMauro Carvalho Chehab
From: Julia Lawall <julia@diku.dk> In the function cx88_audio_initdev, the value card has been created using snd_card_new. The other error handling code in this function frees the value using snd_card_free. I have thus changed the first error case to do the same. On the other hand, it may be that card is not sufficiently initialized at this point to use snd_card_free, in which case something else should be done to free the memory in the error case. In the function snd_cx88_create the call kfree(chip) in one error case looks suspicious, both because it is not done in the other error code, and because chip points into the middle of the memory allocated by snd_card_new, ie it is not itself associated with a separate kmalloc. Therefore I have removed it. The semantic match that finds the first problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @r exists@ local idexpression x; statement S,S1; position p1,p2,p3; expression E,E1; type T,T1; expression *ptr != NULL; @@ ( if ((x@p1 = snd_card_new(...)) == NULL) S | x@p1 = snd_card_new(...); ) ... when != snd_card_free(...,(T)x,...) when != if (...) { <+... snd_card_free(...,(T)x,...) ...+> } when != true x == NULL || ... when != x = E when != E = (T)x when any ( if (x == NULL || ...) S1 | if@p2 (...) { ... when != snd_card_free(...,(T1)x,...) when != if (...) { <+... snd_card_free(...,(T1)x,...) ...+> } when != x = E1 when != E1 = (T1)x ( return \(0\|<+...x...+>\|ptr\); | return@p3 ...; ) } ) @ script:python @ p1 << r.p1; p3 << r.p3; @@ print "* file: %s snd_card_new: %s return: %s" % (p1[0].file,p1[0].line,p3[0].line) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2008-11-20new email addressMauro Carvalho Chehab
From: Jelle Foks <jelle-v4l@foks.us> Please accept this patch to refer to my new email address Priority: normal Signed-off-by: Jelle Foks <jelle@foks.us> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2008-11-11cx88-dvb: MFE attachment clean-up for HVR-3000/4000Mauro Carvalho Chehab
From: Darron Broad <darron@kewl.org> This cleans-up MFE attachment for these cards plus two cases of potential memory leak on attachment failure. Priority: normal Signed-off-by: Darron Broad <darron@kewl.org> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2008-11-09WinFast DTV2000 H: add support for missing analog inputsMauro Carvalho Chehab
From: Vincent Pelletier <plr.vincent@gmail.com> WinFast DTV2000 H: add support for missing analog inputs Add support for the following inputs: - radio tuner - composite 1 & 2 (only 1 is physically available, but composite 2 is also advertised by windows driver) - svideo Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2008-11-09cx88-dvb: Remove usage core->prev_set_voltage from cx24116 based cards.Mauro Carvalho Chehab
From: Igor M. Liplianin <liplianin@me.by> cx88-dvb: Remove usage core->prev_set_voltage from cx24116 based cards. Remove usage core->prev_set_voltage from cx24116 based cards, as it does not make sense for the demod. Signed-off-by: Igor M. Liplianin <liplianin@me.by> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2008-11-09cx88-dvb: Add new cards.Mauro Carvalho Chehab
From: Igor M. Liplianin <liplianin@me.by> Add support for Prof 6200 DVB-S PCI card Add support for Prof 6200 DVB-S PCI card The card based on stv0299 or stv0288 demodulators. Signed-off-by: Igor M. Liplianin <liplianin@me.by> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2008-11-09cx88-dvb: Add new cards.Mauro Carvalho Chehab
From: Igor M. Liplianin <liplianin@me.by> Add support for TurboSight TBS8910 DVB-S PCI card Add support for TurboSight TBS8910 DVB-S PCI card The card based on stv0299 or stv0288 demodulators. Signed-off-by: Igor M. Liplianin <liplianin@me.by> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2008-11-02cx88: add a second PCI ID for ATI TV Wonder ProMauro Carvalho Chehab
From: Patrice Levesque <video2linux.wayne@ptaff.ca> There's a second PCI identifier for the ATI TV WONDER PRO card (0x1002:0x00f9). Attached is a patch to kernel 2.6.27 that adds autodetection for this version. Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2008-10-30cx88-dvb: MFE attachment fix-updarron@kewl.org
From: Darron Broad <darron@kewl.org> MFE attachment fix-up Priority: normal Signed-off-by: Darron Broad <darron@kewl.org>
2008-10-30cx88-mpeg: final fix for analogue only compilation + de-alloc fixdarron@kewl.org
From: Darron Broad <darron@kewl.org> Final fix for when analogue only is selected for compilation (ie, !CX88_DVB) This tidies up previous fix and adds missing de-alloc memory leak on fault (eg, if fe1 fails to alloc where fe0 was allocated). Priority: normal Signed-off-by: Darron Broad <darron@kewl.org>
2008-10-30Simplify video standards enumerationMauro Carvalho Chehab
From: Mauro Carvalho Chehab <mchehab@redhat.com> Priority: normal Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2008-10-30tda9887/cx88: secam-bghdarron@kewl.org
From: Frederic CAND <frederic.cand@anevia.com> Adds secam bgh support Signed-off-by: Frederic CAND <frederic.cand@anevia.com>
2008-10-30cx88-blackbird: bugfix: cx88-blackbird-mpeg-usersdarron@kewl.org
From: Frederic CAND <frederic.cand@anevia.com> Allows multiple access to the mpeg device Signed-off-by: Frederic CAND <frederic.cand@anevia.com>
2008-10-30cx88-blackbird: bugfix: cx88-blackbird-poll-fixdarron@kewl.org
From: Frederic CAND <frederic.cand@anevia.com> Starts encoder not only on a read call but also on a poll command. Signed-off-by: Frederic CAND <frederic.cand@anevia.com>
2008-10-25VBI fix for cx88 cardsMauro Carvalho Chehab
From: Rafael Diniz <diniz@wimobilis.com.br> The attached patch fix VBI support cx88 card. I'm running a capture for hours, getting the closed caption from it[1], and it's working perfect - the output is the same of a bttv card. Please apply this patch as soon as possible. [1] - using zvbi-ntsc-cc of zvbi project. Signed-off-by: Rafael Diniz <diniz@wimobilis.com.br> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2008-10-24cx88-dvb: Fix Oops in case i2c bus failed to registerMauro Carvalho Chehab
From: Matthias Schwarzott <zzam@gentoo.org> There already is an report at kernel bugzilla about this issue: http://bugzilla.kernel.org/show_bug.cgi?id=9455 When enabling extra checks for the i2c-bus of cx88 based cards by loading i2c_algo_bit with bit_test=1 this may trigger an oops when loading cx88_dvb. This is caused by the extra check code that detects that the sda-line is stuck high and thus does not register the i2c-bus. cx88-dvb however does not check if the i2c-bus is valid and just uses core->i2c_adap to attach dvb frontend modules. This leads to an oops at the first call to i2c_transfer: $ modprobe i2c_algo_bit bit_test=1 $ modprobe cx8802 cx88/2: cx2388x MPEG-TS Driver Manager version 0.0.6 loaded cx88[0]: quirk: PCIPCI_NATOMA -- set TBFX cx88[0]: subsystem: 0070:9202, board: Hauppauge Nova-S-Plus DVB-S [card=37,autodetected], frontend(s): 1 cx88[0]: TV tuner type 4, Radio tuner type -1 cx88[0]: SDA stuck high! cx88[0]: i2c register FAILED input: cx88 IR (Hauppauge Nova-S-Plus as /class/input/input5 cx88[0]/2: cx2388x 8802 Driver Manager cx88-mpeg driver manager 0000:00:10.2: enabling device (0154 -> 0156) cx88-mpeg driver manager 0000:00:10.2: PCI INT A -> Link[LNKD] -> GSI 9 (level, low) -> IRQ 9 cx88[0]/2: found at 0000:00:10.2, rev: 5, irq: 9, latency: 64, mmio: 0xfb000000 cx8802_probe() allocating 1 frontend(s) cx88/2: cx2388x dvb driver version 0.0.6 loaded cx88/2: registering cx8802 driver, type: dvb access: shared cx88[0]/2: subsystem: 0070:9202, board: Hauppauge Nova-S-Plus DVB-S [card=37] cx88[0]/2: cx2388x based DVB/ATSC card BUG: unable to handle kernel NULL pointer dereference at 00000000 IP: [<e084d4ef>] :i2c_core:i2c_transfer+0x1f/0x80 *pde = 00000000 Modules linked in: cx88_dvb(+) cx8802 cx88xx ir_common i2c_algo_bit tveeprom videobuf_dvb btcx_risc mga drm ipv6 fscpos eeprom nfsd exportfs stv0299 b2c2_flexcop_pci b2c2_flexcop cx24123 s5h1420 ves1x93 dvb_ttpci dvb_core saa7146_vv saa7146 videobuf_dma_sg videobuf_core videodev v4l1_compat ttpci_eeprom lirc_serial lirc_dev usbhid rtc uhci_hcd 8139too i2c_piix4 i2c_core usbcore evdev Pid: 4249, comm: modprobe Not tainted (2.6.27-gentoo #3) EIP: 0060:[<e084d4ef>] EFLAGS: 00010296 CPU: 0 EIP is at i2c_transfer+0x1f/0x80 [i2c_core] EAX: 00000000 EBX: ffffffa1 ECX: 00000002 EDX: d6c71e3c ESI: d80cd050 EDI: d8093c00 EBP: d6c71e20 ESP: d6c71e0c DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 0068 Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2008-10-21cx88: always de-alloc frontends on fault conditiondarron@kewl.org
From: Darron Broad <darron@kewl.org> De-alloc frontends on fault condition. Priority: normal Signed-off-by: Darron Broad <darron@kewl.org>
2008-10-21cx88: dvb_remove debug outputdarron@kewl.org
From: Darron Broad <darron@kewl.org> Add debug output for dvb_remove enter. Priority: normal Signed-off-by: Darron Broad <darron@kewl.org>
2008-10-21cx88: Not all boards that requires cx88-mpeg has frontendsdarron@kewl.org
From: Mauro Carvalho Chehab <mchehab@infradead.org> The multifrontend changes on cx88 assumed that all boards that use cx88-mpeg supports DVB. This is not true. There also a few analog-only boards based on Blackboard design that also uses cx88-mpeg. For those boards, there's no need to allocate dvb frontends. This patch fixes videobuf allocation for those devices. Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
2008-10-21cx88: initial fix for analogue only compilationdarron@kewl.org
From: Darron Broad <darron@kewl.org> Initial fix for when analogue only is selected for compilation (ie, !CX88_DVB) Priority: normal Signed-off-by: Darron Broad <darron@kewl.org>
2008-10-19v4l: use video_device.num instead of minor in video%dHans Verkuil
From: Hans Verkuil <hverkuil@xs4all.nl> The kernel number of a v4l2 node (e.g. videoX, radioX or vbiX) is now independent of the minor number. So instead of using the minor field of the video_device struct one has to use the num field: this always contains the kernel number of the device node. I forgot about this when I did the v4l2 core change, so this patch converts all drivers that use it in one go. Luckily the change is trivial. Priority: high Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl> CC: michael@mihu.de CC: mchehab@infradead.org CC: corbet@lwn.net CC: luca.risolia@studio.unibo.it CC: isely@pobox.com CC: pe1rxq@amsat.org CC: royale@zerezo.com CC: mkrufky@linuxtv.org CC: stoth@linuxtv.org
2008-10-17Patch to remove warning message during cx88-dvb compilationMauro Carvalho Chehab
From: Igor M. Liplianin <liplianin@me.by> Remove warning message during cx88-dvb compilation. Also fixes double underline in function and struct names. Signed-off-by: Igor M. Liplianin <liplianin@me.by> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2008-10-16videobuf: data storage optimisation (2)darron@kewl.org
From: Darron Broad <darron@kewl.org> To optimise data storage even further one other redundant var has been removed. This also removes a redundant assignment. Priority: normal Signed-off-by: Darron Broad <darron@kewl.org> iSigned-off-by: Steven Toth <stoth@linuxtv.org>
2008-10-15cx88: add I2S-ADC tvaudio methoddarron@kewl.org
From: Darron Broad <darron@kewl.org> This adds I2S-ADC tvaudio mode as a formal method of audio delivery. This fixes one bug and adds fm audio via I2S-ADC on cards that support it. The bug occured before when I2S-ADC mode was initiated on composite/s-video open but was then reset within 500ms by the audio thread which used any previous audio tuning details. Priority: normal Signed-off-by: Darron Broad <darron@kewl.org> Signed-off-by: Steven Toth <stoth@linuxtv.org>
2008-10-15cx88: Update of audio routing config for FM radiodarron@kewl.org
This adds audio routing for the hvr-1300/3000/4000 cards enabling FM audio for the I2S ADC method of the cx88. At this time only the HVR-4000 has been tested. It is assumed the HVR-3000/1300 are the same. Priority: normal Signed-off-by: Darron Broad <darron@kewl.org> Signed-off-by: Steven Toth <stoth@linuxtv.org>
2008-10-15videobuf: data storage optimisationdarron@kewl.org
From: Darron Broad <darron@kewl.org> To optimise data storage redundant vars are removed. Priority: normal Signed-off-by: Darron Broad <darron@kewl.org> Signed-off-by: Steven Toth <stoth@linuxtv.org>
2008-10-16cx88: Change spurious buffer message into a debug only messageSteven Toth
From: Steven Toth <stoth@linuxtv.org> A number of users have complained that their syslog often shows this messages but it doesn't impact performance. I'm changing this to a debug message, so developers will still see the message during testing and users will no longer be bothered by this. Priority: normal Signed-off-by: Steven Toth <stoth@linuxtv.org>
2008-10-16cx88: Convert __FUNCTION__ to __func__Steven Toth
From: Steven Toth <stoth@linuxtv.org> cx88: Convert __FUNCTION__ to __func__ Priority: normal Signed-off-by: Steven Toth <stoth@linuxtv.org>
2008-10-15merge: http://www.linuxtv.org/hg/~stoth/mfeMauro Carvalho Chehab
From: Mauro Carvalho Chehab <mchehab@redhat.com> Priority: normal Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2008-10-11cx88: Add intial config for FM radio supportdarron@kewl.org
From: Darron Broad <darron@kewl.org> This add initial configuration for radio support on the hvr-3000/4000. FM radio doesn't work as yet without further patches (to come), but this prepares for that. Experimental radio support shows that it works when combined with additional audio routing work for cards with an FMD1216ME analogue frontend, but not the MEX variant (more later). Priority: normal Signed-off-by: Darron Broad <darron@kewl.org>
2008-10-11cx88: Add audio routing for the hvr-3000/4000darron@kewl.org
From: Darron Broad <darron@kewl.org> This adds audio routing on the hvr-3000/4000 This is a preliminary patch for later routing requirements. This adds line-in support on the 2 cards mentioned. It is also apparent that there is an initial open fault for line-in when opening composite/s-video. This will be fixed later. It was also noticed that the bit-field for audio routing which was 2 bits needs an increase as the WM8775 for example, allows a value 4 bits wide for it's audio mux. Priority: normal Signed-off-by: Darron Broad <darron@kewl.org>
2008-10-11MFE: Add multi-frontend mutual exclusiondarron@kewl.org
From: Darron Broad <darron@kewl.org> This add frontend R/W mutual exclusion. Prior to this point in time it was possible to open both frontends simultaneously which an MFE card cannot support. In order to stop this, a delayed open is performed which has the following function: Return EBUSY after a configurable amount of time if a frontend is unavailable due to the other being in use. Only allow opening of a frontend if the kernel thread of the other has stopped. This solution was chosen to allow switching between frontends to work as seamlessly as possible. When both frontends are actually opened simultaneously then one will only open, but if quick switching is performed between one of many then the new open will succeed in a clean fashion rather than interrupting a kernel thread. Priority: normal Signed-off-by: Darron Broad <darron@kewl.org>
2008-10-11MFE: cx88: Reset cx22702 on hvr-3000/4000darron@kewl.org
From: Darron Broad <darron@kewl.org> The cx22702 is now always reset on module load. Prior to this the cx22702 was not found on i2c scan without a full reset. Priority: normal Signed-off-by: Darron Broad <darron@kewl.org>
2008-10-11MFE: Add configurable gate controldarron@kewl.org
From: Darron Broad <darron@kewl.org> This adds a configurable (one per card) gate control option for multi-frontend. Prior to this point gate control was assumed to be on the primary frontend, this is a fault when the gate to the analogue section is on the secondary which is the default for both the HVR-3000 and HVR-4000 in MFE. Priority: normal Signed-off-by: Darron Broad <darron@kewl.org>
2008-10-11MFE: Fix a number of bugs and some tidying updarron@kewl.org
From: Darron Broad <darron@kewl.org> A number of reference to videobuf_dvb_get_frontend used an invalid index. This has been fixed. The section for the HVR3000 in advise_acquire was redundant as the same logic is used on the HVR4000. This has been removed and both cards now use the same function. A number of small errors and whitespace errors are also fixed. Priority: normal Signed-off-by: Darron Broad <darron@kewl.org>
2008-10-11S2API: Add Multiple-frontend on a single adapter support.darron@kewl.org
From: Steven Toth <stoth@linuxtv.org> A detailed description from the original patches 2 years ago: "The WinTV-HVR3000 has a single transport bus which is shared between a DVB-T and DVB-S modulator. These patches build on the bus acquisition cx88 work from a few weeks ago to add support for this. So to applications the HVR3000 looks like this: /dev/dvb/adapter0/fe0 (cx24123 DVB-S demod) /dev/dvb/adapter0/fe1 (cx22702 DVB-T demod) Additional boards continue as before, eg: /dev/dvb/adapter1/fe0 (lgdt3302 ATSC demod) The basic change is removing the single instance of the videobuf_dvb in cx8802_dev and saa7134_dev(?) and replacing it with a list and some supporting functions. *NOTE* This branch was taken before v4l-dvb was closed for 2.6.19 so two or three current cx88 patches appear to be reversed by this tree, this will be cleaned up in the near future. The patches missing change the mutex handing to core->lock, fix an enumeration problem." It should be recognised that a number of people have been maintaining this patchset. Significant levels of Kudos to everyone one involved, including but not limited to: Darron Broad Fabio M. Di Nitto Carlo Scarfoglio Hans Werner Without the work of these people, and countless others, my two year old patches would of died on the Mercurial linuxtv.org vine a long time ago. TODO: Revise these patches a little further so that the need for demux1 and dvr0 is optional, not mandatory on the HVR3000. HISTORY (darron): This is the last update to MFE prepared by Hans which is based upon the `scratchpad' diff created by Carlo. All MFE work prior to that point must be attributed to Fabio who ported and maintained Steve's original patch up to that time. Priority: normal Signed-off-by: Steven Toth <stoth@linuxtv.org> Signed-off-by: Darron Broad <darron@kewl.org>
2008-10-13merge: http://linuxtv.org/hg/~stoth/s2Mauro Carvalho Chehab
From: Mauro Carvalho Chehab <mchehab@redhat.com> Priority: normal Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2008-10-08Added support for Prof 7300 DVB-S/S2 cardsOleg Roitburd
From: Oleg Roitburd <oroitburd@gmail.com> Added support for Prof 7300 DVB-S/S2 card. The card based on cx24116 demodulator. Signed-off-by: Oleg Roitburd <oroitburd@gmail.com>
2008-10-01merge: http://www.linuxtv.org/hg/~stoth/s2Mauro Carvalho Chehab
From: Mauro Carvalho Chehab <mchehab@redhat.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2008-09-25cx88: Bugfix: all client disconnects put the frontend to sleep.Steven Toth
From: Darron Broad <darron@kewl.org> From the author: "This fixes the problem where previously all client disconnects put the analogue frontend into standby. In the following example, the first command is succesfully watching TV but the second command which returns EBUSY detunes the receiver by entering it into the standby state. tvtime -d /dev/video0 & cat /dev/video0 " Priority: normal Signed-off-by: Steven Toth <stoth@linuxtv.org> Signed-off-by: Darron Broad <darron@kewl.org>
2008-09-24merge: http://www.linuxtv.org/hg/~stoth/s2Mauro Carvalho Chehab
From: Mauro Carvalho Chehab <mchehab@redhat.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2008-09-23Add support for ST STV0288 demodulator and cards with it.Igor M. Liplianin
From: Georg Acher <acher@baycom.de> From: Igor M. Liplianin <liplianin@me.by> Add support for ST STV0288 demodulator and cards with it, such as TeVii S420. Signed-off by: Georg Acher <acher@baycom.de> Signed-off-by: Igor M. Liplianin <liplianin@me.by>
2008-09-22cx88: HVR3000 / 4000 GPIO related changesSteven Toth
From: Steven Toth <stoth@linuxtv.org> Patch by Darron Broad. Priority: normal Signed-off-by: Steven Toth <stoth@linuxtv.org>
2008-09-22cx88: Enable TDA9887 on HVR1300 / 3000 / 4000Steven Toth
From: Steven Toth <stoth@linuxtv.org> Patch provided by Darron Broad. Priority: normal Signed-off-by: Steven Toth <stoth@linuxtv.org>
2008-09-22S2API: Add Kconf dependencySteven Toth
From: Steven Toth <stoth@linuxtv.org> Patch provided by Darron Broad Priority: normal Signed-off-by: Steven Toth <stoth@linuxtv.org>
2008-09-17Added support for TBS 8920 DVB-S/S2 cardOleg Roitburd
From: Oleg Roitburd <oroitburd@gmail.com> Added support for TBS 8920 DVB-S/S2 card. The card based on cx24116 demodulator. Signed-off-by: Oleg Roitburd <oroitburd@gmail.com>
2008-09-17Added support for Omicom SS4 DVB-S/S2 cardoleg@compaq.Office.local
From: Oleg Roitburd <oroitburd@gmail.com> Added support for Omicom SS4 DVB-S/S2 card. The card based on cx24116 demodulator. Signed-off-by: Oleg Roitburd <oroitburd@gmail.com> user: Oleg Roitburd <oroitburd@gmail.com>
2008-09-21HVR3000/4000 Hauppauge related IR cleanupsSteven Toth
From: Darron Broad <darron@kewl.org> From the author: This patch-set fixes remote control issues I have experienced with hauppauge drivers in Linux since the PVR-350 and now with both a NOVA-S+ and HVR-4000. It has also been confirmed to work with an HVR-1300 user who had exactly the same issue. Hauppage remote controls use RC5. RC5 has a bit-field which represents the target device. The hauppauge windows drivers have a registry key which can enable filtering, but the linux drivers will accept any target device in this bit field for internal processing. This causes problems with setups such as mythtv where remote control key presses destined for the TV (target = 0) are interpreted by the kernel and subsequenctly LIRC then mythtv. Of the remote controls I have to hand (wintv black, pvr/hvr silver) the hauppauge remotes send one of two device targets ids, these are interpreted by the patch which then filters out any non hauppauge addresses. Priority: normal Signed-off-by: Steven Toth <stoth@linuxtv.org> Signed-off-by: Darron Broad <darron@kewl.org>