summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKlaus Schmidinger <vdr@tvdr.de>2003-10-26 13:19:22 +0100
committerKlaus Schmidinger <vdr@tvdr.de>2003-10-26 13:19:22 +0100
commiteb63966268ba2695a34bfbbff502266384e74047 (patch)
tree268037a77540870b164d4c526d1709bd00ead299
parentc23a93f302733f97c125f67689e04988d396faea (diff)
downloadvdr-eb63966268ba2695a34bfbbff502266384e74047.tar.gz
vdr-eb63966268ba2695a34bfbbff502266384e74047.tar.bz2
Fixed handling CAM menus in case the CAM connection fails while the menu is being presented
-rw-r--r--CONTRIBUTORS4
-rw-r--r--HISTORY5
-rw-r--r--ci.c54
-rw-r--r--ci.h4
4 files changed, 51 insertions, 16 deletions
diff --git a/CONTRIBUTORS b/CONTRIBUTORS
index a669fab7..7f1c548a 100644
--- a/CONTRIBUTORS
+++ b/CONTRIBUTORS
@@ -852,6 +852,10 @@ Markus Hardt <markus.hardt@gmx.net>
Thomas Rausch <Thomas.Rausch@gmx.de>
for making VDR try to get a timer's channel without RID when loading 'timers.conf'
+Thomas v. Keller <v.keller@neckarufer.de>
+ for reporting a crash in case the CAM connection fails while a CAM menu
+ is being presented
+
Emil Petersky <petersky@isr.uni-stuttgart.de>
for adding "Slovak Link" and "Czech Link" to 'ca.conf'
diff --git a/HISTORY b/HISTORY
index 632be97d..f021d700 100644
--- a/HISTORY
+++ b/HISTORY
@@ -2445,6 +2445,11 @@ Video Disk Recorder Revision History
Oliver Endriss).
- Fixed handling comments in editing marks.
+2003-10-26: Version 1.2.6pre4
+
+- Fixed handling CAM menus in case the CAM connection fails while the menu
+ is being presented (thanks to Thomas v. Keller for reportign this one).
+
2003-10-24: Version 1.3.0
- Changed thread handling to make it work with NPTL ("Native Posix Thread Library").
diff --git a/ci.c b/ci.c
index e94c20a0..889c8538 100644
--- a/ci.c
+++ b/ci.c
@@ -4,7 +4,7 @@
* See the main source file 'vdr.c' for copyright information and
* how to reach the author.
*
- * $Id: ci.c 1.16 2003/08/02 10:00:01 kls Exp $
+ * $Id: ci.c 1.17 2003/10/26 13:04:23 kls Exp $
*/
/* XXX TODO
@@ -1004,15 +1004,15 @@ bool cCiDateTime::Process(int Length, const uint8_t *Data)
class cCiMMI : public cCiSession {
private:
char *GetText(int &Length, const uint8_t **Data);
- cCiMenu *menu;
- cCiEnquiry *enquiry;
+ cCiMenu *menu, *fetchedMenu;
+ cCiEnquiry *enquiry, *fetchedEnquiry;
public:
cCiMMI(int SessionId, cCiTransportConnection *Tc);
virtual ~cCiMMI();
virtual bool Process(int Length = 0, const uint8_t *Data = NULL);
virtual bool HasUserIO(void) { return menu || enquiry; }
- cCiMenu *Menu(void);
- cCiEnquiry *Enquiry(void);
+ cCiMenu *Menu(bool Clear = false);
+ cCiEnquiry *Enquiry(bool Clear = false);
bool SendMenuAnswer(uint8_t Selection);
bool SendAnswer(const char *Text);
};
@@ -1021,13 +1021,21 @@ cCiMMI::cCiMMI(int SessionId, cCiTransportConnection *Tc)
:cCiSession(SessionId, RI_MMI, Tc)
{
dbgprotocol("New MMI (session id %d)\n", SessionId);
- menu = NULL;
- enquiry = NULL;
+ menu = fetchedMenu = NULL;
+ enquiry = fetchedEnquiry = NULL;
}
cCiMMI::~cCiMMI()
{
+ if (fetchedMenu) {
+ cMutexLock MutexLock(&fetchedMenu->mutex);
+ fetchedMenu->mmi = NULL;
+ }
delete menu;
+ if (fetchedEnquiry) {
+ cMutexLock MutexLock(&fetchedEnquiry->mutex);
+ fetchedEnquiry->mmi = NULL;
+ }
delete enquiry;
}
@@ -1123,18 +1131,26 @@ bool cCiMMI::Process(int Length, const uint8_t *Data)
return true;
}
-cCiMenu *cCiMMI::Menu(void)
+cCiMenu *cCiMMI::Menu(bool Clear)
{
- cCiMenu *m = menu;
- menu = NULL;
- return m;
+ if (Clear)
+ fetchedMenu = NULL;
+ else if (menu) {
+ fetchedMenu = menu;
+ menu = NULL;
+ }
+ return fetchedMenu;
}
-cCiEnquiry *cCiMMI::Enquiry(void)
+cCiEnquiry *cCiMMI::Enquiry(bool Clear)
{
- cCiEnquiry *e = enquiry;
- enquiry = NULL;
- return e;
+ if (Clear)
+ fetchedEnquiry = NULL;
+ else if (enquiry) {
+ fetchedEnquiry = enquiry;
+ enquiry = NULL;
+ }
+ return fetchedEnquiry;
}
bool cCiMMI::SendMenuAnswer(uint8_t Selection)
@@ -1170,6 +1186,9 @@ cCiMenu::cCiMenu(cCiMMI *MMI, bool Selectable)
cCiMenu::~cCiMenu()
{
+ cMutexLock MutexLock(&mutex);
+ if (mmi)
+ mmi->Menu(true);
free(titleText);
free(subTitleText);
free(bottomText);
@@ -1188,6 +1207,7 @@ bool cCiMenu::AddEntry(char *s)
bool cCiMenu::Select(int Index)
{
+ cMutexLock MutexLock(&mutex);
if (mmi && -1 <= Index && Index < numEntries)
return mmi->SendMenuAnswer(Index + 1);
return false;
@@ -1210,11 +1230,15 @@ cCiEnquiry::cCiEnquiry(cCiMMI *MMI)
cCiEnquiry::~cCiEnquiry()
{
+ cMutexLock MutexLock(&mutex);
+ if (mmi)
+ mmi->Enquiry(true);
free(text);
}
bool cCiEnquiry::Reply(const char *s)
{
+ cMutexLock MutexLock(&mutex);
return mmi ? mmi->SendAnswer(s) : false;
}
diff --git a/ci.h b/ci.h
index 62046e5a..6b81a18c 100644
--- a/ci.h
+++ b/ci.h
@@ -4,7 +4,7 @@
* See the main source file 'vdr.c' for copyright information and
* how to reach the author.
*
- * $Id: ci.h 1.8 2003/05/25 11:44:47 kls Exp $
+ * $Id: ci.h 1.9 2003/10/26 12:22:09 kls Exp $
*/
#ifndef __CI_H
@@ -21,6 +21,7 @@ class cCiMenu {
private:
enum { MAX_CIMENU_ENTRIES = 64 }; ///< XXX is there a specified maximum?
cCiMMI *mmi;
+ cMutex mutex;
bool selectable;
char *titleText;
char *subTitleText;
@@ -45,6 +46,7 @@ class cCiEnquiry {
friend class cCiMMI;
private:
cCiMMI *mmi;
+ cMutex mutex;
char *text;
bool blind;
int expectedLength;