diff options
| author | František Dvořák <valtri@users.sourceforge.net> | 2006-03-26 18:15:03 +0000 |
|---|---|---|
| committer | František Dvořák <valtri@users.sourceforge.net> | 2006-03-26 18:15:03 +0000 |
| commit | 124347b154ae981d3a4997a4f98f7c3e620a673a (patch) | |
| tree | 837b3d614ae75ff554b4711eb6b090689bba5cfc | |
| parent | 326a991366d9266bab8796016392fa217464b263 (diff) | |
| download | xine-lib-124347b154ae981d3a4997a4f98f7c3e620a673a.tar.gz xine-lib-124347b154ae981d3a4997a4f98f7c3e620a673a.tar.bz2 | |
[coverity]
Small change due to false positive:
CID: 258
Checker: REVERSE_INULL (help)
File: xine-lib/src/libw32dll/wine/win32.c
Function: expRegOpenKeyA
Description: Pointer "phkResult" dereferenced before NULL check
Debug output fix:
CID: 259
Checker: REVERSE_INULL (help)
File: xine-lib/src/libw32dll/wine/win32.c
Function: expSetFilePointer
Description: Pointer "ext" dereferenced before NULL check
CVS patchset: 7952
CVS date: 2006/03/26 18:15:03
| -rw-r--r-- | src/libw32dll/wine/win32.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/libw32dll/wine/win32.c b/src/libw32dll/wine/win32.c index dcab43ea5..09ed78c32 100644 --- a/src/libw32dll/wine/win32.c +++ b/src/libw32dll/wine/win32.c @@ -1892,7 +1892,7 @@ static long WINAPI expRegSetValueExA(long key, const char* name, long v1, long v static long WINAPI expRegOpenKeyA (long hKey, LPCSTR lpSubKey, int* phkResult) { long result=RegOpenKeyExA(hKey, lpSubKey, 0, 0, phkResult); - dbgprintf("RegOpenKeyExA(key 0x%x, subkey '%s', 0x%x) => %d\n", + dbgprintf("RegOpenKeyExA(key 0x%x, subkey '%s', 0x%p) => %d\n", hKey, lpSubKey, phkResult, result); if(!result && phkResult) dbgprintf(" New key: 0x%x\n", *phkResult); return result; @@ -3631,7 +3631,7 @@ static WIN_BOOL WINAPI expWriteFile(HANDLE h,LPCVOID pv,DWORD size,LPDWORD wr,LP static DWORD WINAPI expSetFilePointer(HANDLE h, LONG val, LPLONG ext, DWORD whence) { int wh; - dbgprintf("SetFilePointer(%d, 0x%x, 0x%x = %d, %d)\n", h, val, ext, *ext, whence); + dbgprintf("SetFilePointer(%d, 0x%x, 0x%x = %d, %d)\n", h, val, ext, ext ? *ext : -1, whence); //why would DLL want temporary file with >2Gb size? switch(whence) { |