Make _x_canonicalise_url an inline function, as it's only ever used once (either in input_http or in the test for http_helper).

2 files changed, 23 insertions, 24 deletions

diff --git a/src/input/http_helper.c b/src/input/http_helper.c
index 83562c9dc..f4950a084 100644
--- a/src/input/http_helper.c
+++ b/src/input/http_helper.c
@@ -220,29 +220,6 @@ error:
   return 0;  
 }
 
-char *_x_canonicalise_url (const char *base, const char *url) {
-
-  size_t base_length;
-  char *cut, *ret;
-
-  if ((cut = strstr (url, "://")))
-    return strdup (url);
-
-  cut = strstr (base, "://");
-  if (url[0] == '/') {
-    /* absolute - base up to first '/' after "://", then url */
-    cut = strchr (cut + 3, '/');
-  }
-  else {
-    /* relative - base up to & inc. last '/', then url */
-    cut = strrchr (cut, '/');
-    if (cut)
-      ++cut;
-  }
-  base_length = cut ? (size_t)(cut - base) : strlen (base);
-  asprintf (&ret, "%.*s%s", (int)base_length, base, url);
-  return ret;
-}
 
 #ifdef TEST_URL
 /*
diff --git a/src/input/http_helper.h b/src/input/http_helper.h
index 3ce3f2b7c..9baa05235 100644
--- a/src/input/http_helper.h
+++ b/src/input/http_helper.h
@@ -43,6 +43,28 @@ int _x_parse_url (char *url, char **proto, char** host, int *port,
  * return:
  *   the canonicalised URL (caller must free() it)
  */
-char *_x_canonicalise_url (const char *base, const char *url);
+static inline char *_x_canonicalise_url (const char *base, const char *url) {
+
+  size_t base_length;
+  char *cut, *ret;
+
+  if ((cut = strstr (url, "://")))
+    return strdup (url);
+
+  cut = strstr (base, "://");
+  if (url[0] == '/') {
+    /* absolute - base up to first '/' after "://", then url */
+    cut = strchr (cut + 3, '/');
+  }
+  else {
+    /* relative - base up to & inc. last '/', then url */
+    cut = strrchr (cut, '/');
+    if (cut)
+      ++cut;
+  }
+  base_length = cut ? (size_t)(cut - base) : strlen (base);
+  asprintf (&ret, "%.*s%s", (int)base_length, base, url);
+  return ret;
+}
 
 #endif /* HTTP_HELPER_H */