Rewrite get_help function to use asprintf, without declaring the two help1/help2 strings and without running two gettext() calls at every get_help() call.

1 files changed, 11 insertions, 14 deletions

diff --git a/src/post/planar/pp.c b/src/post/planar/pp.c
index 3f9c0d745..1213c82df 100644
--- a/src/post/planar/pp.c
+++ b/src/post/planar/pp.c
@@ -20,6 +20,8 @@
  * plugin for ffmpeg libpostprocess
  */
 
+#include <config.h>
+
 #include "xine_internal.h"
 #include "post.h"
 #include "xineutils.h"
@@ -102,23 +104,18 @@ static xine_post_api_descr_t * get_param_descr (void) {
 }
 
 static char * get_help (void) {
-  char *help1 = 
-         _("FFmpeg libpostprocess plugin.\n"
-           "\n"
-           "Parameters\n"
-           "\n");
-   
-  char *help2 =
-         _("\n"
-           "* libpostprocess (C) Michael Niedermayer\n"
-         );
   static char *help = NULL;
 
   if( !help ) {
-    help = malloc( strlen(help1) + strlen(help2) + strlen(pp_help) + 1);
-    strcpy(help, help1);
-    strcat(help, pp_help);
-    strcat(help, help2);
+    asprintf(&help, "%s%s%s",
+	     _("FFmpeg libpostprocess plugin.\n"
+	       "\n"
+	       "Parameters\n"
+	       "\n"),
+	     pp_help,
+	     _("\n"
+	       "* libpostprocess (C) Michael Niedermayer\n")
+	     );
   }
   return help;
 }