diff options
| author | Simon Farnsworth <simon.farnsworth@onelan.co.uk> | 2007-07-12 11:29:42 +0100 |
|---|---|---|
| committer | Simon Farnsworth <simon.farnsworth@onelan.co.uk> | 2007-07-12 11:29:42 +0100 |
| commit | 33d32c6238d0d5d9ae00a2fee6bba2c987ff0f21 (patch) | |
| tree | 55390bf452acab3e73c37eb5ba162a66644e4da2 /TODO | |
| parent | 7cb04769574d9ef849ca7a7bd4da45671639eb77 (diff) | |
| download | xine-lib-33d32c6238d0d5d9ae00a2fee6bba2c987ff0f21.tar.gz xine-lib-33d32c6238d0d5d9ae00a2fee6bba2c987ff0f21.tar.bz2 | |
Fix thread leak in DVB subtitles, and enhance spec compliance
When leaving xine playing DVB with subtitles for a long period of time,
I noticed a gradual increase in memory use, caused by it creating more
and more timeout threads. In addition, the existing thread was not safe
w.r.t destruction of the decoder, and would occasionally segfault xine.
Further, EN 300 743 states that the timeout should be sent by the
broadcaster; the existing thread had a constant 6 second timeout,
whereas (e.g.) BBC NEWS 24 subtitles are broadcast with a 15 second
timeout. In theory, this could result in subtitles being hidden in error.
This rework changes the thread to pick up a timeout set by
draw_subtitles; in addition, it uses pthread condition variables to
avoid any need to kill and recreate the thread.
Diffstat (limited to 'TODO')
0 files changed, 0 insertions, 0 deletions