summaryrefslogtreecommitdiff
path: root/src/libflac
diff options
context:
space:
mode:
authorDiego 'Flameeyes' Pettenò <flameeyes@gmail.com>2006-07-10 22:08:12 +0000
committerDiego 'Flameeyes' Pettenò <flameeyes@gmail.com>2006-07-10 22:08:12 +0000
commite70c5600f5653c6915931717bdd52f9a6a2f2d9d (patch)
treea0d5282f9deb660def1026701c8e68a273099ede /src/libflac
parent32ad3ca6265c8cbac584dd3510109b920415a8e1 (diff)
downloadxine-lib-e70c5600f5653c6915931717bdd52f9a6a2f2d9d.tar.gz
xine-lib-e70c5600f5653c6915931717bdd52f9a6a2f2d9d.tar.bz2
Implement visibility support, available on GCC 4.0 and later and on some 3.4 (through backports), to avoid exporting unneeded internal symbols, making plugins' loading faster and use of internal copies of libraries more solid. It should automatically fall back to the old way in GCCs that does not support -fvisibility=hidden, but has to be tested carefully. No issues were found in the months of testing in Gentoo, but this requires special attention anyway.
CVS patchset: 8101 CVS date: 2006/07/10 22:08:12
Diffstat (limited to 'src/libflac')
-rw-r--r--src/libflac/Makefile.am5
-rw-r--r--src/libflac/decoder_flac.c2
2 files changed, 3 insertions, 4 deletions
diff --git a/src/libflac/Makefile.am b/src/libflac/Makefile.am
index bd49237dc..12304ff84 100644
--- a/src/libflac/Makefile.am
+++ b/src/libflac/Makefile.am
@@ -1,7 +1,5 @@
include $(top_srcdir)/misc/Makefile.common
-AM_CFLAGS = $(LIBFLAC_CFLAGS)
-
if HAVE_FLAC
flac_module = xineplug_flac.la
endif
@@ -12,6 +10,7 @@ lib_LTLIBRARIES = $(flac_module)
xineplug_flac_la_SOURCES = demux_flac.c decoder_flac.c
xineplug_flac_la_LIBADD = $(LIBFLAC_LIBS) $(XINE_LIB)
-xineplug_flac_la_LDFLAGS = -avoid-version -module -lFLAC @XINE_PLUGIN_MIN_SYMS@
+xineplug_flac_la_CFLAGS = $(LIBFLAC_CFLAGS) $(VISIBILITY_FLAG)
+xineplug_flac_la_LDFLAGS = -avoid-version -module
noinst_HEADERS = demux_flac.h
diff --git a/src/libflac/decoder_flac.c b/src/libflac/decoder_flac.c
index 65f4422ca..a568e27e3 100644
--- a/src/libflac/decoder_flac.c
+++ b/src/libflac/decoder_flac.c
@@ -400,7 +400,7 @@ static const decoder_info_t dec_info_audio = {
5 /* priority */
};
-const plugin_info_t xine_plugin_info[] = {
+const plugin_info_t xine_plugin_info[] EXPORTED = {
/* type, API, "name", version, special_info, init_function */
{ PLUGIN_DEMUX, 26, "flac", XINE_VERSION_CODE, NULL, demux_flac_init_class },
{ PLUGIN_AUDIO_DECODER, 15, "flacdec", XINE_VERSION_CODE, &dec_info_audio, init_plugin },