Rationalise __attribute__((packed)) usage.

First of all, as we check the presence of the attribute in configure.ac and
we generate the XINE_PACKED definition there, there's no need to do the work
again on attributes.h.

Also remove #pragma pack support for now, as the trick is just not neat enough,
and as it is it's just noise.

Make Wine, libdvdnav and nosefart use XINE_PACKED rather than doing their own
checks, as they are less reliable.

1 files changed, 3 insertions, 1 deletions

diff --git a/src/libxineadec/nosefart/nsf.h b/src/libxineadec/nosefart/nsf.h
index 163e2f62f..79ec1dbb6 100644
--- a/src/libxineadec/nosefart/nsf.h
+++ b/src/libxineadec/nosefart/nsf.h
@@ -30,6 +30,8 @@
 #include "nes6502.h"
 #include "nes_apu.h"
 
+#include "config.h"
+
 #define  NSF_MAGIC   "NESM\x1A"
 
 #define  NSF_DEDICATED_PAL       0x01
@@ -96,7 +98,7 @@ typedef struct nsf_s
 
    /* our main processing routine, calls all external mixing routines */
    void (*process)(void *buffer, int num_samples);
-} __PACKED__ nsf_t;
+} XINE_PACKED nsf_t;
 
 /* Function prototypes */
 extern void nsf_init(void);