summaryrefslogtreecommitdiff
path: root/win32
diff options
context:
space:
mode:
authorVille Skyttä <ville.skytta@iki.fi>2008-02-09 16:54:22 +0000
committerVille Skyttä <ville.skytta@iki.fi>2008-02-09 16:54:22 +0000
commitdae0b9aa3ace07691519827151cffe667602d341 (patch)
tree6b9f80022edef4838cdfe2f9bbdc4f4b70d3b772 /win32
parent34af4adde1c65495fa8948c482ef83bd73204d89 (diff)
downloadxine-lib-dae0b9aa3ace07691519827151cffe667602d341.tar.gz
xine-lib-dae0b9aa3ace07691519827151cffe667602d341.tar.bz2
Make xine-config --version parsing more robust
I think there's quite a bit more room for improvement in the sed expression: 1) The expression is not bound to start/end of line, and will thus pass possible leading/trailing garbage through. 2) It uses plain "." (== any character as far as sed is concerned) where it appears to search for the literal ".". 3) The whole "xine-config --version" output is assigned to all xine_config_*_version vars if there's no match. I think more intuitive would be them to be empty if parsing fails. 4) It uses * (0 or more) for matching digit sequences, where I think + (1 or more) would be desirable. This patch should fix issues 1 to 3. I suppose for 4) it would additionally take only replacing the first three "*" with "\+" but IIRC there are some portability issues related to "+" between different sed versions.
Diffstat (limited to 'win32')
0 files changed, 0 insertions, 0 deletions