Project

General

Profile

Actions
Copy link

Feature #1328

open

New option to subtitle comparison

Added by mikkom over 11 years ago. Updated over 11 years ago.

Status:
Feedback
Priority:
Normal
Assignee:
-
Category:
-
Start date:
04/05/2013
Due date:
% Done:

0%

Estimated time:

Description

The attached patch adds a new "compare if present" option to subtitle comparison. The current choices do not cover (for me personally, and for some others as well, see http://projects.vdr-developer.org/issues/1055) the most typical use case i.e. matching against subtitle in case it exists and ignoring the comparison if the subtitle is missing. The "if present" option could also be renamed to something more descriptive, say "no match if not present" (maybe not the best wording but I had trouble coming up with a better one).

Files

improve-subtitle-comparison.diff (2.76 KB) improve-subtitle-comparison.diff mikkom, 04/05/2013 02:30 PM
Actions
Copy link
 #1

Updated by winni over 11 years ago

  • Status changed from New to Feedback

Hi mikkom,

if I get this right, your patch adds the following:

If there's no subtitle, then handle the two events as equal, so do no additional recording. If there is a subtitle, compare them as usual.

At least with my EPG this would not be useful. Normally there is an episode name for a series, but sometimes it happens that the provider skips it. In your case this would give me no additional 'safety' recording, which actually would not be a repeat, but only a new episode without a name. What is your most typical case?

If I apply the patch we should also find suitible terms that describe what is meant ;-)

cheers,
Christian

Actions
Copy link

Also available in: Atom PDF