Actions
Feature #852
openMakefile improvements
Status:
Feedback
Priority:
Low
Assignee:
-
Target version:
-
Start date:
01/15/2012
Due date:
% Done:
0%
Estimated time:
Description
See attachment for further details.
Files
Actions
Added by idl0r almost 13 years ago. Updated over 7 years ago.
0%
Description
See attachment for further details.
Files
| 0001-Minor-Makefile-improvements.patch (2.3 KB) 0001-Minor-Makefile-improvements.patch | idl0r, 01/15/2012 08:15 PM |
I'm considering applying at least some of these changes in some form. But here's a few comments:
I don't like the "Do not override VDRDIR, LIBDIR and TMPDIR" part. If this is desirable, it should be done in VDR's "newplugin".
I also have some reservations regarding the WANT_I18N stuff. What's the use case for not building the translations? Like the "don't override" stuff, I tend to think this is something that should be in VDR's own Makefile as well as its newplugin if it's desirable.
scop wrote:
I'm considering applying at least some of these changes in some form. But here's a few comments:
I don't like the "Do not override VDRDIR, LIBDIR and TMPDIR" part. If this is desirable, it should be done in VDR's "newplugin".
Well.. It's just to keep the user specified values when specified. That's all.
This is esp. important for package maintainer.
I also have some reservations regarding the WANT_I18N stuff. What's the use case for not building the translations? Like the "don't override" stuff, I tend to think this is something that should be in VDR's own Makefile as well as its newplugin if it's desirable.
The point is that not everybody wants locales. It also requires to have gettext available during build time. With my patch this is fully optional and enabled by default.
Everybody can decide himself whether to install/enable locales or not.
I also send a similar patch to kls and hopefully he'll apply it.