Fixed problems related to VTP filter streaming like ringbuffer overflows,

stuttering or aborting video stream (refs #2045)

Toerless Eckert wrote:

This patch tries to resolve problems in streamdev-client that
can occur when enabling "StreamFilters". Enabling this option
is necessary to receive certain programs with dynamic PIDs such as
some german "regional" broadcast (eg: NDR).

Problem:

Without this fix, the following behavior was observed on a Raspberry
PI running streamdev-0.6.1-git with VDR-2.6.1:

- Buffer overflows of filter data
- Stop/go video on channels
- Total stopping of video

More logs in:

http://www.vdr-portal.de/board16-video-disk-recorder/board55-vdr-plugins/125237-
streamdev-client-filter-daten-streamen-ndr-raspberry-haengt/

Analysis:

VDR expect section data from filters separately from the
main program stream. Historically, it received each filter data
via a separate file descriptor from the DVB card. In the streamdev-client
module, a socketpair is used to feed filter data to the main VDR code.
During certain operations in VDR, such as startup or channel change
(depending also on the speed of initialization of the video output driver),
VDR does not consume the filter data as fast as it is provided by
streamdev-client, resulting in overflow of the default socket buffers
used by streamdev-client.

To add to the problem of overflowing the socketpair buffers, the
streamdev-client code sends several times a second short packets into
the socketpair to determine if the receiving side (VDR) has closed
the socketpair (IsClosed(), CarbageCollect()). This further clogs
up the socketpair() buffer.

The raspberry PI socketpair buffering behavior seems to be the same
as that of other 3.x linux systems, the socket buffer size is by
default 163840, and it can be increased via sysctl net.core.wmem_max.
During startup, it can take up to 10 seconds before VDR will consume
filter data, so the socketpair buffer can fill up with 10 seconds worth
of data.

Solution

1. IsClosed()/CarbageCollect() where removed from client/filter.c
and replaced by explicitly tracking when VDR closes a filter socket.
This alone seems to already resolve the problem of hanging or stop&go
video and seems to be sufficient to receive dynamic-PID channels reliably.

2. filter.c was enhanced to request a larger socket buffer size
if config option FilterSockBufSize is set.

3. If supported (if streamdev-client runs on linux), the socketpair
queue is "flushed" to reduce the amount of "random" packet drop messages
and to rather drop sequential messages.

9 files changed, 126 insertions, 100 deletions

diff --git a/client/po/de_DE.po b/client/po/de_DE.po
index f347fe9..a3d1c8b 100644
--- a/client/po/de_DE.po
+++ b/client/po/de_DE.po
@@ -6,8 +6,8 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: streamdev 0.5.0\n"
-"Report-Msgid-Bugs-To: <http://www.vdr-developer.org/mantisbt/>\n"
-"POT-Creation-Date: 2013-01-20 23:46+0100\n"
+"Report-Msgid-Bugs-To: <vdrdev@schmirler.de>\n"
+"POT-Creation-Date: 2014-10-20 22:57+0200\n"
 "PO-Revision-Date: 2008-03-30 02:11+0200\n"
 "Last-Translator: Frank Schmirler <vdrdev@schmirler.de>\n"
 "Language-Team: German <vdr@linuxtv.org>\n"
@@ -16,18 +16,6 @@ msgstr ""
 "Content-Type: text/plain; charset=ISO-8859-15\n"
 "Content-Transfer-Encoding: 8bit\n"
 
-msgid "VTP Streaming Client"
-msgstr "VTP Streaming Client"
-
-msgid "Suspend Server"
-msgstr "Server pausieren"
-
-msgid "Server is suspended"
-msgstr "Server ist pausiert"
-
-msgid "Couldn't suspend Server!"
-msgstr "Konnte Server nicht pausieren!"
-
 msgid "Hide Mainmenu Entry"
 msgstr "Hauptmenüeintrag verstecken"
 
@@ -46,6 +34,9 @@ msgstr "Timeout (s)"
 msgid "Filter Streaming"
 msgstr "Filter-Daten streamen"
 
+msgid "Filter SockBufSize"
+msgstr "Filter Socket Puffergröße"
+
 msgid "Live TV Priority"
 msgstr "Live TV Priorität"
 
@@ -57,3 +48,15 @@ msgstr "Maximale Priorität"
 
 msgid "Broadcast Systems / Cost"
 msgstr "Empfangssysteme / Kosten"
+
+msgid "VTP Streaming Client"
+msgstr "VTP Streaming Client"
+
+msgid "Suspend Server"
+msgstr "Server pausieren"
+
+msgid "Server is suspended"
+msgstr "Server ist pausiert"
+
+msgid "Couldn't suspend Server!"
+msgstr "Konnte Server nicht pausieren!"
diff --git a/client/po/es_ES.po b/client/po/es_ES.po
index 5182453..15cb64f 100644
--- a/client/po/es_ES.po
+++ b/client/po/es_ES.po
@@ -6,8 +6,8 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: streamdev 0.5.0\n"
-"Report-Msgid-Bugs-To: <http://www.vdr-developer.org/mantisbt/>\n"
-"POT-Creation-Date: 2013-01-28 22:16+0100\n"
+"Report-Msgid-Bugs-To: <vdrdev@schmirler.de>\n"
+"POT-Creation-Date: 2015-01-16 22:32+0100\n"
 "PO-Revision-Date: 2010-06-19 03:58+0100\n"
 "Last-Translator: Javier Bradineras <jbradi@hotmail.com>\n"
 "Language-Team: Spanish <vdr@linuxtv.org>\n"
@@ -16,18 +16,6 @@ msgstr ""
 "Content-Type: text/plain; charset=ISO-8859-15\n"
 "Content-Transfer-Encoding: 8bit\n"
 
-msgid "VTP Streaming Client"
-msgstr "Cliente trasmisión VTP"
-
-msgid "Suspend Server"
-msgstr "Suspender servidor"
-
-msgid "Server is suspended"
-msgstr "Servidor en suspensión"
-
-msgid "Couldn't suspend Server!"
-msgstr "Imposible suspender el servidor!"
-
 msgid "Hide Mainmenu Entry"
 msgstr "Ocultar entrada en menú principal"
 
@@ -46,6 +34,9 @@ msgstr ""
 msgid "Filter Streaming"
 msgstr "Filtrar transmisión"
 
+msgid "Filter SockBufSize"
+msgstr ""
+
 msgid "Live TV Priority"
 msgstr ""
 
@@ -57,3 +48,15 @@ msgstr "Prioridad máxima"
 
 msgid "Broadcast Systems / Cost"
 msgstr ""
+
+msgid "VTP Streaming Client"
+msgstr "Cliente trasmisión VTP"
+
+msgid "Suspend Server"
+msgstr "Suspender servidor"
+
+msgid "Server is suspended"
+msgstr "Servidor en suspensión"
+
+msgid "Couldn't suspend Server!"
+msgstr "Imposible suspender el servidor!"
diff --git a/client/po/fi_FI.po b/client/po/fi_FI.po
index 6b55ac5..afe56a4 100644
--- a/client/po/fi_FI.po
+++ b/client/po/fi_FI.po
@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: streamdev 0.5.0\n"
 "Report-Msgid-Bugs-To: <vdrdev@schmirler.de>\n"
-"POT-Creation-Date: 2013-01-28 22:16+0100\n"
+"POT-Creation-Date: 2015-01-16 22:32+0100\n"
 "PO-Revision-Date: 2008-03-30 02:11+0200\n"
 "Last-Translator: Rolf Ahrenberg\n"
 "Language-Team: Finnish <vdr@linuxtv.org>\n"
@@ -16,18 +16,6 @@ msgstr ""
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 
-msgid "VTP Streaming Client"
-msgstr "VTP-suoratoistoasiakas"
-
-msgid "Suspend Server"
-msgstr "Pysäytä palvelin"
-
-msgid "Server is suspended"
-msgstr "Palvelin on pysäytetty"
-
-msgid "Couldn't suspend Server!"
-msgstr "Palvelinta ei onnistuttu pysäyttämään!"
-
 msgid "Hide Mainmenu Entry"
 msgstr "Piilota valinta päävalikosta"
 
@@ -46,6 +34,9 @@ msgstr "Yhteyden aikakatkaisu (s)"
 msgid "Filter Streaming"
 msgstr "Suodatetun tiedon suoratoisto"
 
+msgid "Filter SockBufSize"
+msgstr ""
+
 msgid "Live TV Priority"
 msgstr "Live-katselun prioriteetti"
 
@@ -57,3 +48,15 @@ msgstr "Suurin prioriteetti"
 
 msgid "Broadcast Systems / Cost"
 msgstr "Lähetysjärjestelmien suhdeluku"
+
+msgid "VTP Streaming Client"
+msgstr "VTP-suoratoistoasiakas"
+
+msgid "Suspend Server"
+msgstr "Pysäytä palvelin"
+
+msgid "Server is suspended"
+msgstr "Palvelin on pysäytetty"
+
+msgid "Couldn't suspend Server!"
+msgstr "Palvelinta ei onnistuttu pysäyttämään!"
diff --git a/client/po/fr_FR.po b/client/po/fr_FR.po
index 7d938f0..1441df5 100644
--- a/client/po/fr_FR.po
+++ b/client/po/fr_FR.po
@@ -6,8 +6,8 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: streamdev 0.5.0\n"
-"Report-Msgid-Bugs-To: <http://www.vdr-developer.org/mantisbt/>\n"
-"POT-Creation-Date: 2013-01-28 22:16+0100\n"
+"Report-Msgid-Bugs-To: <vdrdev@schmirler.de>\n"
+"POT-Creation-Date: 2015-01-16 22:32+0100\n"
 "PO-Revision-Date: 2008-03-30 02:11+0200\n"
 "Last-Translator: micky979 <micky979@free.fr>\n"
 "Language-Team: French <vdr@linuxtv.org>\n"
@@ -16,18 +16,6 @@ msgstr ""
 "Content-Type: text/plain; charset=ISO-8859-15\n"
 "Content-Transfer-Encoding: 8bit\n"
 
-msgid "VTP Streaming Client"
-msgstr "Client de streaming VTP"
-
-msgid "Suspend Server"
-msgstr "Suspendre le serveur"
-
-msgid "Server is suspended"
-msgstr "Le serveur est suspendu"
-
-msgid "Couldn't suspend Server!"
-msgstr "Impossible de suspendre le serveur!"
-
 msgid "Hide Mainmenu Entry"
 msgstr "Masquer dans le menu principal"
 
@@ -46,6 +34,9 @@ msgstr ""
 msgid "Filter Streaming"
 msgstr "Filtre streaming"
 
+msgid "Filter SockBufSize"
+msgstr ""
+
 msgid "Live TV Priority"
 msgstr ""
 
@@ -57,3 +48,15 @@ msgstr ""
 
 msgid "Broadcast Systems / Cost"
 msgstr ""
+
+msgid "VTP Streaming Client"
+msgstr "Client de streaming VTP"
+
+msgid "Suspend Server"
+msgstr "Suspendre le serveur"
+
+msgid "Server is suspended"
+msgstr "Le serveur est suspendu"
+
+msgid "Couldn't suspend Server!"
+msgstr "Impossible de suspendre le serveur!"
diff --git a/client/po/it_IT.po b/client/po/it_IT.po
index c311507..a1323c2 100644
--- a/client/po/it_IT.po
+++ b/client/po/it_IT.po
@@ -8,8 +8,8 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: streamdev 0.5.0\n"
-"Report-Msgid-Bugs-To: <http://www.vdr-developer.org/mantisbt/>\n"
-"POT-Creation-Date: 2013-01-28 22:16+0100\n"
+"Report-Msgid-Bugs-To: <vdrdev@schmirler.de>\n"
+"POT-Creation-Date: 2015-01-16 22:32+0100\n"
 "PO-Revision-Date: 2012-06-10 20:34+0100\n"
 "Last-Translator: Diego Pierotto <vdr-italian@tiscali.it>\n"
 "Language-Team: Italian <vdr@linuxtv.org>\n"
@@ -18,18 +18,6 @@ msgstr ""
 "Content-Type: text/plain; charset=utf-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 
-msgid "VTP Streaming Client"
-msgstr "Client trasmissione VTP"
-
-msgid "Suspend Server"
-msgstr "Sospendi Server"
-
-msgid "Server is suspended"
-msgstr "Server sospeso"
-
-msgid "Couldn't suspend Server!"
-msgstr "Impossibile sospendere il server!"
-
 msgid "Hide Mainmenu Entry"
 msgstr "Nascondi voce menu principale"
 
@@ -48,6 +36,9 @@ msgstr "Scadenza (s)"
 msgid "Filter Streaming"
 msgstr "Filtra trasmissione"
 
+msgid "Filter SockBufSize"
+msgstr ""
+
 msgid "Live TV Priority"
 msgstr "Priorità TV dal vivo"
 
@@ -59,3 +50,15 @@ msgstr "Priorità massima"
 
 msgid "Broadcast Systems / Cost"
 msgstr "Costo / sistemi trasmissione"
+
+msgid "VTP Streaming Client"
+msgstr "Client trasmissione VTP"
+
+msgid "Suspend Server"
+msgstr "Sospendi Server"
+
+msgid "Server is suspended"
+msgstr "Server sospeso"
+
+msgid "Couldn't suspend Server!"
+msgstr "Impossibile sospendere il server!"
diff --git a/client/po/lt_LT.po b/client/po/lt_LT.po
index 409c267..01927f6 100644
--- a/client/po/lt_LT.po
+++ b/client/po/lt_LT.po
@@ -6,8 +6,8 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: streamdev 0.5.0\n"
-"Report-Msgid-Bugs-To: <http://www.vdr-developer.org/mantisbt/>\n"
-"POT-Creation-Date: 2013-01-28 22:16+0100\n"
+"Report-Msgid-Bugs-To: <vdrdev@schmirler.de>\n"
+"POT-Creation-Date: 2015-01-16 22:32+0100\n"
 "PO-Revision-Date: 2009-11-26 21:57+0200\n"
 "Last-Translator: Valdemaras Pipiras <varas@ambernet.lt>\n"
 "Language-Team: Lithuanian <vdr@linuxtv.org>\n"
@@ -16,18 +16,6 @@ msgstr ""
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
 
-msgid "VTP Streaming Client"
-msgstr "VTP transliavimo standartas"
-
-msgid "Suspend Server"
-msgstr "Sustabdyti serverį"
-
-msgid "Server is suspended"
-msgstr "Serveris sustabdytas"
-
-msgid "Couldn't suspend Server!"
-msgstr "Negali sustabdyti serverio!"
-
 msgid "Hide Mainmenu Entry"
 msgstr "Paslėpti pagrindinio meniu įrašą"
 
@@ -46,6 +34,9 @@ msgstr ""
 msgid "Filter Streaming"
 msgstr "Filtruoti transliavimÄ…"
 
+msgid "Filter SockBufSize"
+msgstr ""
+
 msgid "Live TV Priority"
 msgstr ""
 
@@ -57,3 +48,15 @@ msgstr "Maksimalus prioritetas"
 
 msgid "Broadcast Systems / Cost"
 msgstr ""
+
+msgid "VTP Streaming Client"
+msgstr "VTP transliavimo standartas"
+
+msgid "Suspend Server"
+msgstr "Sustabdyti serverį"
+
+msgid "Server is suspended"
+msgstr "Serveris sustabdytas"
+
+msgid "Couldn't suspend Server!"
+msgstr "Negali sustabdyti serverio!"
diff --git a/client/po/pl_PL.po b/client/po/pl_PL.po
index 7058f96..599139c 100644
--- a/client/po/pl_PL.po
+++ b/client/po/pl_PL.po
@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: vdr-streamdev-client 0.6.1-git\n"
 "Report-Msgid-Bugs-To: <vdrdev@schmirler.de>\n"
-"POT-Creation-Date: 2014-11-20 14:11+0100\n"
+"POT-Creation-Date: 2015-01-16 22:32+0100\n"
 "PO-Revision-Date: 2014-11-24 18:07+0100\n"
 "Last-Translator: Tomasz Maciej Nowak <tomek_n@o2.pl>\n"
 "Language-Team: Polish <vdr@linuxtv.org>\n"
@@ -35,6 +35,9 @@ msgstr "Czas oczekiwania (s)"
 msgid "Filter Streaming"
 msgstr "Filtruj strumieñ"
 
+msgid "Filter SockBufSize"
+msgstr ""
+
 msgid "Live TV Priority"
 msgstr "Priorytet lokalnych ur±dzeñ"
 
diff --git a/client/po/ru_RU.po b/client/po/ru_RU.po
index 8f5a9b2..b2ff56c 100644
--- a/client/po/ru_RU.po
+++ b/client/po/ru_RU.po
@@ -6,8 +6,8 @@
 msgid ""
 msgstr ""
 "Project-Id-Version: streamdev 0.5.0\n"
-"Report-Msgid-Bugs-To: <http://www.vdr-developer.org/mantisbt/>\n"
-"POT-Creation-Date: 2013-01-28 22:16+0100\n"
+"Report-Msgid-Bugs-To: <vdrdev@schmirler.de>\n"
+"POT-Creation-Date: 2015-01-16 22:32+0100\n"
 "PO-Revision-Date: 2008-06-26 15:36+0100\n"
 "Last-Translator: Oleg Roitburd <oleg@roitburd.de>\n"
 "Language-Team: Russian <vdr@linuxtv.org>\n"
@@ -16,18 +16,6 @@ msgstr ""
 "Content-Type: text/plain; charset=ISO-8859-5\n"
 "Content-Transfer-Encoding: 8bit\n"
 
-msgid "VTP Streaming Client"
-msgstr "VTP Streaming ÚÛØÕÝâ"
-
-msgid "Suspend Server"
-msgstr "¾áâÐÝÞÒØâì áÕàÒÕà"
-
-msgid "Server is suspended"
-msgstr "ÁÕàÒÕà ÞáâÐÝÞÒÛÕÝ"
-
-msgid "Couldn't suspend Server!"
-msgstr "ÝÕ ÜÞÓã ÞáâÐÝÞÒØâì áÕàÒÕà"
-
 msgid "Hide Mainmenu Entry"
 msgstr "ÁßàïâÐâì Ò ÓÛÐÒÝÞÜ ÜÕÝî"
 
@@ -46,6 +34,9 @@ msgstr ""
 msgid "Filter Streaming"
 msgstr "ÄØÛìâà ßÞâÞÚÐ"
 
+msgid "Filter SockBufSize"
+msgstr ""
+
 msgid "Live TV Priority"
 msgstr ""
 
@@ -57,3 +48,15 @@ msgstr ""
 
 msgid "Broadcast Systems / Cost"
 msgstr ""
+
+msgid "VTP Streaming Client"
+msgstr "VTP Streaming ÚÛØÕÝâ"
+
+msgid "Suspend Server"
+msgstr "¾áâÐÝÞÒØâì áÕàÒÕà"
+
+msgid "Server is suspended"
+msgstr "ÁÕàÒÕà ÞáâÐÝÞÒÛÕÝ"
+
+msgid "Couldn't suspend Server!"
+msgstr "ÝÕ ÜÞÓã ÞáâÐÝÞÒØâì áÕàÒÕà"
diff --git a/client/po/sk_SK.po b/client/po/sk_SK.po
index 65f9a10..76374f6 100755
--- a/client/po/sk_SK.po
+++ b/client/po/sk_SK.po
@@ -7,7 +7,7 @@ msgid ""
 msgstr ""
 "Project-Id-Version: streamdev_SK\n"
 "Report-Msgid-Bugs-To: <vdrdev@schmirler.de>\n"
-"POT-Creation-Date: 2013-03-13 14:20+0100\n"
+"POT-Creation-Date: 2015-01-16 22:32+0100\n"
 "PO-Revision-Date: \n"
 "Last-Translator: Milan Hrala <hrala.milan@gmail.com>\n"
 "Language-Team: Slovak <hrala.milan@gmail.com>\n"
@@ -36,6 +36,9 @@ msgstr "Èasový limit (s)"
 msgid "Filter Streaming"
 msgstr "Filtrova» dátový prúd"
 
+msgid "Filter SockBufSize"
+msgstr ""
+
 msgid "Live TV Priority"
 msgstr "Priorita ¾ivého vysielania"
 
@@ -59,4 +62,3 @@ msgstr "Server je doèasne pozastavený"
 
 msgid "Couldn't suspend Server!"
 msgstr "Server sa nepodarilo pozastavi»!"
-