diff options
| author | František Dvořák <valtri@users.sourceforge.net> | 2006-03-26 17:20:11 +0000 |
|---|---|---|
| committer | František Dvořák <valtri@users.sourceforge.net> | 2006-03-26 17:20:11 +0000 |
| commit | 326a991366d9266bab8796016392fa217464b263 (patch) | |
| tree | 89b1776354169e9ca006f94cc3aca5d17c2c2a58 /src | |
| parent | 6f3b838762dca7b17560aec9a059ff048def702d (diff) | |
| download | xine-lib-326a991366d9266bab8796016392fa217464b263.tar.gz xine-lib-326a991366d9266bab8796016392fa217464b263.tar.bz2 | |
[coverity]
Fixed simple bug in destroying.
CID: 260
Checker: REVERSE_INULL (help)
File: xine-lib/src/libw32dll/DirectShow/outputpin.c
Function: COutputPin_Destroy
Description: Pointer "(This)->mempin" dereferenced before NULL check
CVS patchset: 7951
CVS date: 2006/03/26 17:20:11
Diffstat (limited to 'src')
| -rw-r--r-- | src/libw32dll/DirectShow/outputpin.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/libw32dll/DirectShow/outputpin.c b/src/libw32dll/DirectShow/outputpin.c index e6317a985..f971951f3 100644 --- a/src/libw32dll/DirectShow/outputpin.c +++ b/src/libw32dll/DirectShow/outputpin.c @@ -428,10 +428,11 @@ static void COutputPin_SetNewFormat(COutputPin* This, const AM_MEDIA_TYPE* amt) static void COutputPin_Destroy(COutputPin* This) { - if (This->mempin->vt) - free(This->mempin->vt); - if (This->mempin) + if (This->mempin) { + if (This->mempin->vt) + free(This->mempin->vt); free(This->mempin); + } if (This->vt) free(This->vt); free(This); |