summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2007-06-06Clean up .tar.bz2 as well as .tar.gz.Darren Salt
2007-06-06Changelog entry for the fb colour conversion crash fix.Darren Salt
2007-06-06[PATCH] video_out_fb crashSteve Freeland
I discovered some problems with the framebuffer output driver. The first problem I had was a segfault when trying to play a 480x360 clip on a 640x480 display. I traced it to the yuv420_rgb16() color conversion function, which was overrunning the input buffer (the "y" part of the image). The reason was that it was being called downstack from fb_frame_proc_slice(), multiple times for each 16-pixel high horizontal slice of the image. When it got to the last slice, only 8 pixels were left to the bottom but it still tried to process a 16-pixel high slice. Nosing around a bit, I compared the configuration of the color converter as used by the fb driver to the xshm driver and found some oddities: 1) The color converter was configured with a "source height" of 16 pixels no matter what the size of the image, and a "dest height" based on what was referred to within video_out_fb.c as a "stripe" -- essentially an input slice scaled up or down as required by the output size. 2) Apparently to prevent the above from causing problems, the position in the output buffer was managed by special code -- see the "stripe_incr" variable. 3) The xshm driver calls yuv2rgb_next_slice() with a NULL argument at the beginning of each frame to allow the color converter to reset its tracking of the slice-by-slice progress through the image; the fb driver does not. I'm not sure exactly why it was done that way, but my best guess would be that whoever coded it didn't know about the need to call yuv2rgb_next_slice() with a NULL argument, and the rest was built up to get it to mostly work without that. The attached patch changes the behaviour to match that of the xshm driver, and also removes the reset_dest_pointers() function, replacing its single invocation with one to fb_frame_field(), which is identical after removing the "stripe" management. It fixed my crash. Can anyone see if I've misunderstood what was going on? If not, it should probably be applied to the official version.
2007-06-05Silence an ignored error when running "debuild clean".Darren Salt
2007-06-05Disable aRTs output plugin by default, it's deprecated and will be removed ↵Diego 'Flameeyes' Pettenò
in 1.2 series.
2007-06-04Changelog entry for the unplug codeMatthias Kretz
2007-06-04fallback to none output when the device is unpluggedMatthias Kretz
2007-06-04handle unplugged devices in audio_alsa_out (return -1) and in audio_out ↵Matthias Kretz
close the driver on a return value <0
2007-06-03Changelog entry for the MPEG PES change.Darren Salt
2007-06-03[patch] Fix video pid misdetectionAndrew de Quincey
Hi, the next bug that has been annoying me is as follows. I have some streams recorded from BBC4 on UK DVB-T. BBC4 only actually starts transmitting at about 7pm; prior to that there is a static picture saying it is not playing just now. With these streams and xine, I would get audio, but no picture. Looking at the PMT table during the static picture, all the streams have type 0x0b. However there IS a video stream in there, but there are also several streams of binary data. Xine's current video PID auto-detection code was locking on to one of these streams of binary data because it contained the magic sequence 00 00 01 e0 at one of the PUS. *HOWEVER* it is NOT a PES stream; this sequence is just an accident. The other problem is that xine can only handle one video stream; so once it was misdetected once, it was stuck at that PID. The attached patch changes the corrupted_pes flag into a counter. If a video stream has more than CORRUPT_PES_THRESHOLD corrupt PES packets in a row, then it is deselected as the video stream, and auto-detection is kicked off again. Auto-detection will now also ignore any streams seen previously which have a nonzero corrupted_pes count. This works very well; I can now see the video fine. One possible issue might be that if you get a lot of corrupt PES in a stream which really IS the video stream, it will be deselected. However, this is not actually a problem: once the corruption goes away, the corrupted_pes counter will be reset to 0, and the stream will once again be autodetected as the video stream (and playback will continue from there).
2007-06-03[PATCH] remove uneeded %s from it translationRiccardo Magliocchetti
2007-06-03Add a comment & changelog entry for the mmap bug fix.Darren Salt
2007-06-03[patch] Nasty mmap problem with huge filesAndrew de Quincey
Hi, I've been tracking down a very odd bug this afternoon. As it turns out it is caused by enabling xine's mmap() support for the input_file.c. I'm running 32 bit linux 2.6.21. The file in question is 0x10e4da000 bytes long (you can probably guess what kind of bug this is by now :) Anyway, the issue stems from the definition of mmap(): void *mmap(void *start, size_t length, int prot, int flags, int fd, off_t offset); compare this to the definition of st_size in struct stat: off_t st_size; /* total size, in bytes */ On my machine (in input_file.c) sizeof(size_t) ==4, whilst sizeof(off_t) == 8. However the compiler doesn't generate a warning when the following is done in xine's code: if ( (this->mmap_base = mmap(NULL, sbuf.st_size, PROT_READ, MAP_SHARED, this->fh, 0)) != (void*)-1 So it silently truncates the upper part of the length. Obviously you cannot mmap() a file that large into (32 bit) memory anyway, but as it turns out, mmapping() 0xe4da000 succeeds, which causes... problems. The patch (against xine-lib 1.1.6) does two things: * Check that the length will not be truncated, while still allowing for mmap()s of large files under 64 bit OSes. * A correctness fix: if mmap() fails, this->mmap_base will be set to 0xffffffff. Later on when the file is closed, this means it was attempting to do munmap(0xffffffff).
2007-06-02Conflict with libxine2-dev.Darren Salt
2007-06-02Bump libtool revision number.Darren Salt
2007-06-02Add a -doc package, allowing libxine1 and libxine2 to be installed together.Darren Salt
2007-06-01Port Simon Farnsworth's xv deinterlacing fix to xcbxv.Darren Salt
2007-06-01Prioritise the musepack demuxer over mpgaudio, as sometimes the latter can ↵Bram Verweij
misfire and report a good file as unplayable.
2007-05-31Merge.Diego 'Flameeyes' Pettenò
2007-05-31Don't include the local copy of frame.h and synth.h when building with ↵Diego 'Flameeyes' Pettenò
external libmad.
2007-05-31Patch: fix parsing qt/mov embedded referncesClaudio Ciccani
The attached patch fixes a problem with embedded references in recent versions of quicktime's movie formats. Apparently there is an additional atom (RMRA) before the RMDA atom: it works like a container for all subsequent atoms, so it can be safely skipped. You can test yourself what I'm saying by watching some trailers at apple.com (http://www.apple.com/trailers). -- Regards, Claudio Ciccani klan@users.sf.net http://directfb.org http://sf.net/projects/php-directfb
2007-05-29Actually id3v2_tagsize was used by demux_mpgaudio and demux_aac; but as it ↵Diego 'Flameeyes' Pettenò
makes little sense, move BE_*_synchsafe functions from id3.c to id3.h and declare them inline, then BE_32_synchsafe can be replaced to id3v2_tagsize as drop in.
2007-05-29Use the integer versions of Speex decoding functions, this avoids an ↵Diego 'Flameeyes' Pettenò
iteration over the decoded frames to transform them to integer, and also avoids an improper saturation.
2007-05-29Add a ChangeLog entry.Diego 'Flameeyes' Pettenò
2007-05-29Fix typo reporting ID3v2.4 tags as ID3v2.3.Diego 'Flameeyes' Pettenò
2007-05-29Print the invalid header flags when found.Diego 'Flameeyes' Pettenò
2007-05-29Add a comment about id3v2_istag function and remove id3v2_tagsize function ↵Diego 'Flameeyes' Pettenò
(was used by demux_flac only).
2007-05-29Correctly parse ID3 tags, and avoid skipping over them manually. This ↵Diego 'Flameeyes' Pettenò
reduces again the amount of troublesome FLAC files.
2007-05-29Esperanto by Antonio C. Codazzi "La Filozofo" <f_sophia libero it>Philipp Matthias Hahn
2007-05-28Replaced the hardcoded opcodes with "rdtsc" notation, make the rdtsc() ↵Stas Sergeev
function static.
2007-05-28Add an x86_64-specific version of rdtsc().Stas Sergeev
2007-05-26Re: [xine-devel] vcd plugin - sigsegv in 1.1.6 and 1.1(.7)Manfred Tremmel
development branche Am Samstag, 26. Mai 2007 17:48 schrieb Darren Salt: > Could you also try not reverting that and instead applying one or > both of the attached patches? Both playback and eject need to be > tested. You should use the drive's eject button, though there's no > harm in also checking xine-lib's eject code. Ok, here's a modified patch, a combination of your two patches, with a little fix. It works fine here, pressing the vcd button on xine-ui starts playing vcd's directly and when pressing the stop button, I can eject the CD by pressing the eject button on the cd drive. I hope it's ok for you. -- Machs gut | http://www.iivs.de/schwinde/buerger/tremmel/ | http://packman.links2linux.de/ Manfred | http://www.knightsoft-net.de
2007-05-20Add stdout redirection to the example scan command.Darren Salt
2007-05-20Mention other methods of getting the current dir; use shell quoting.Darren Salt
2007-05-20Make it clearer that the notes immediately below the MRL summary are important.Darren Salt
2007-05-17Convert character constants to hex values for redability in UTF-8 terminals.Darren Salt
Add and adjust comments appropriately.
2007-05-17Convert comments (and the occasional string where it doesn't matter) to UTF-8.Darren Salt
2007-05-17Convert AUTHORS to UTF-8. Add some now-useable accents & use ß where preferred.Darren Salt
2007-05-16v4l: replace faulty use of xprintf with lprintf.Simon Farnsworth
The current input_v4l in xine-lib 1.1.6 is inherently buggy (it will deference an invalid pointer in extract_mrl if the MRL contains a V4L input name or frequency).
2007-05-02[PATCH] Remove packet count from demux_ts, to remove a long delaySimon Farnsworth
The attached patch applies after my logging patches (I can regenerate if needed). demux_ts attempted to read packets from the input 200 times before giving up. When playing a local file, this is harmless, as it will hit EOF 200 times; however, input_dvb waits 5 seconds for packets on each call to read, resulting in a 1000 second delay if tuning fails. Remove the counting of input packets, and add a comment to read() in input_plugin.h, to indicate that we expect inputs to try and return some data when read() is called. This fixes the delay, and makes it clear to future maintainers that they shouldn't expect to loop like this. -- Simon Farnsworth
2007-05-02[PATCH] Enhance logging in demux_ts, input_dvb and video_out_xvSimon Farnsworth
The three attached patches (against 1.1.6) each increase the amount of debug logging in their respective components. We've found the extra logging useful when trying to track down faults. I've split this into three patches to make it easier to apply only some of our changes. -- Comments welcome, Simon Farnsworth
2007-05-13DVB MRL documentation corrections, additions and tweaks.Darren Salt
Add documentation for dvba: MRLs. Mention that the service ID is required for dvbs:, dvbc: and dvbt:. Replace _ with - in the DVB tuning info descriptions (for formatting reasons).
2007-05-13Correct the dvba:// MRL / tuner mismatch message.Darren Salt
2007-05-11Throw a XINE_MSG_PERMISSION_ERROR error when HTTP returns a 401 statushadess@cookie.hadess.net
Patch from Dmitri Fedortchenko <dimo <at> angelhill.net>, required for upstream Totem bug: http://bugzilla.gnome.org/show_bug.cgi?id=418316
2007-05-04[PATCH] Fix deinterlacing in video_out_xv.cSimon Farnsworth
Xv drivers are permitted to return a bigger image than we asked for, to work around hardware constraints. If this happens, 1.1.6's video_out_xv cannot deinterlace properly. Fix this by deinterlacing based on the width of the Xv image; the Xv driver will discard the extra horizontal data. Without this patch, you get a barber-pole effect if the input video is interlaced *and* the Xv driver chooses to round up the width of the requested image. -- Simon Farnsworth
2007-05-06Changelog entries.Darren Salt
2007-05-06Merge Reinhard Nissl's xxmc fixes and related changes.Darren Salt
2007-05-06Merge Reinhard Nissl's MPEG2 fixes and optimisations.Darren Salt
2007-05-06Merge Reinhard Nissl's ffmpeg fixes.Darren Salt
2007-05-06Merge Reinhard Nissl's demuxer fixes.Darren Salt