Bug #1069
open
Option -s (start in suspended mode) does not work anymore
Added by Anonymous about 12 years ago.
Updated about 12 years ago.
Description
Starting vdr-softhddevice with option '-s' has no effect anymore. VDR is starting fine, but the plugin runs directly in 'attached' mode. Detaching/attaching using SVDRP commands 'atta'/'resu' works flawlessly. Latest commit '0cf4598f680bdb14f7bb235027e4eec8b5205e91' was used, some older versions were working fine.
Files
Additional info: I'm using the following command line:
--plugin=softhddevice -d :0 -g 1920x1080+0+0 -v vdpau -p hw:1,7 -s
I digged a bit into the latest commits and reverted some changes. It seems to be related to the changes done in revision ecb48a5d. When reverting the changes that have been done to the class destructor cSoftHdControl::~cSoftHdControl()
, it works fine again!
You find my logfile attached (startup without my revert-back changes). Please let me know when additional info is required.
- Status changed from New to Confirmed
- Assignee set to johns
- Priority changed from Normal to High
This patch restores the old behavior, but it was not correct.
It should be possible to use the remote to wakeup the plugin.
diff --git a/softhddevice.cpp b/softhddevice.cpp
index 05a7ace..ad73848 100644
--- a/softhddevice.cpp
+++ b/softhddevice.cpp
@@ -1997,8 +1997,9 @@ bool cPluginSoftHdDevice::Start(void)
switch (::Start()) {
case 1:
- cControl::Launch(new cSoftHdControl);
- cControl::Attach();
+ //cControl::Launch(new cSoftHdControl);
+ //cControl::Attach();
+ // FIXME: VDR overwrites the control
SuspendMode = SUSPEND_NORMAL;
break;
case -1:
Thanks for your quick response - I tested your patch now and it works well! Your comment sounds as this is not the final fix which will go into GIT, right?
Btw: I really like your plugin! I'm using VDR since 6 years now and softhddevice is much better than messing around with xineliboutput and all the required patches which depends on certain xine-lib, ffmpeg and VDR versions. It's also more stable and channel switching is significantly faster! Keep up the good work!
- % Done changed from 0 to 50
This is now in GIT.
Yes this is not the final bug fix, because the remote can't be used to wakeup the vdr.
The dummy player should be started later.
Also available in: Atom
PDF